feat: Add missing VPC connection for Compute Instance#577
Open
zubitripathy wants to merge 11 commits intoterraform-google-modules:mainfrom
Open
feat: Add missing VPC connection for Compute Instance#577zubitripathy wants to merge 11 commits intoterraform-google-modules:mainfrom
zubitripathy wants to merge 11 commits intoterraform-google-modules:mainfrom
Conversation
Added connections to the network variable for specifying source and version.
zubitripathy
requested review from
a team,
ayushmjain,
erlanderlo,
krprabhat-eng and
q2w
as code owners
krprabhat-eng
approved these changes
Apr 14, 2026
auto-merge was automatically disabled
April 14, 2026 09:10
Head branch was pushed to by a user without write access
…adata, and confidential computing example
…terraform lock file
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding missing VPC connection for Compute Instance.
Testing Steps for VPC Connection:
Prepared and used the Automation script for implementing missing connections in ADC (currently in testing phase) to perform the below steps:
Adding components and connections and filling up param values (ADC Canvas):
a) In the ADC canvas, add the custom Compute Instance and VPC components.
b) Add a connection line between the two. This stage also passed successfully.
c) Fill all required configuration parameters for all 2 components (e.g., region, project, name, network and subnet details, etc)
d) [Created an Instance template manually in the same project and region. Added that as a configuration parameter value for Compute Instance]
App Deployment:
a) Create a new application with the connected components.
b) Deploy and ensure the application deployment completes successfully.
c) Iterate in case of failures, trying with different values.
Successful testing in Staging environment:
https://screenshot.googleplex.com/ePc8tcspLYjHHmg