Skip to content

fix: Add validation for network acl#1097

Merged
ocofaigh merged 6 commits intomainfrom
add-validation-acl
Jan 22, 2026
Merged

fix: Add validation for network acl#1097
ocofaigh merged 6 commits intomainfrom
add-validation-acl

Conversation

@vburckhardt
Copy link
Copy Markdown
Member

@vburckhardt vburckhardt commented Dec 8, 2025

Description

Same as #1096 for sg - merge after #1096

  • Added validation to the network_acls variable in variables.tf to ensure that each network ACL rule specifies at most one protocol (tcp, udp, or icmp), or omits all to allow all protocols. This prevents users from defining rules with multiple protocols, which could cause configuration errors (API error at apply time).

Release required?

  • No release
  • Patch release (x.x.X)
  • Minor release (x.X.x)
  • Major release (X.x.x)
Release notes content
  • Added validation to the network_acls variable in variables.tf to ensure that each network ACL rule specifies at most one protocol (tcp, udp, or icmp), or omits all to allow all protocols. This prevents users from defining rules with multiple protocols, which could cause configuration errors.

Run the pipeline

If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.

Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:

/run pipeline

Checklist for reviewers

  • If relevant, a test for the change is included or updated with this PR.
  • If relevant, documentation for the change is included or updated with this PR.

For mergers

  • Use a conventional commit message to set the release level. Follow the guidelines.
  • Include information that users need to know about the PR in the commit message. The commit message becomes part of the GitHub release notes.
  • Use the Squash and merge option.

@vburckhardt
Copy link
Copy Markdown
Member Author

/run pipeline

@vburckhardt
Copy link
Copy Markdown
Member Author

/run pipeline

@vburckhardt
Copy link
Copy Markdown
Member Author

/run pipeline

@ocofaigh
Copy link
Copy Markdown
Contributor

/run pipeline

@ocofaigh
Copy link
Copy Markdown
Contributor

Test failed due to a bug thats fixed in #1113
Will rebase once thats merged and retry

@ocofaigh
Copy link
Copy Markdown
Contributor

/run pipeline

@ocofaigh ocofaigh merged commit eeae988 into main Jan 22, 2026
2 checks passed
@ocofaigh ocofaigh deleted the add-validation-acl branch January 22, 2026 10:34
@terraform-ibm-modules-ops
Copy link
Copy Markdown
Contributor

🎉 This PR is included in version 8.12.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants