Skip to content

fix: replace deprecated tcp/udp/icmp SG rule blocks in VSI module #1029

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
piyush117 wants to merge 5 commits into
base: main
Choose a base branch
from
Draft

fix: replace deprecated tcp/udp/icmp SG rule blocks in VSI module #1029

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
addd2be
handled the deprecation warning
piyush117 Feb 16, 2026
c62b477
updated provider version
piyush117 Feb 16, 2026
d098705
Merge branch 'main' into handle-tcp-deprec
piyush117 Feb 23, 2026
934c459
Addressed minor review comments
piyush117 Feb 23, 2026
7e428b6
Merge branch 'main' into handle-tcp-deprec
piyush117 Mar 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -162,7 +162,7 @@ You need the following permissions to run this module.
| Name | Version |
|------|---------|
| <a name="requirement_terraform"></a> [terraform](#requirement\_terraform) | >= 1.9.0 |
| <a name="requirement_ibm"></a> [ibm](#requirement\_ibm) | >= 1.78.4, < 2.0.0 |
| <a name="requirement_ibm"></a> [ibm](#requirement\_ibm) | >= 1.87.3, < 2.0.0 |
| <a name="requirement_time"></a> [time](#requirement\_time) | >= 0.9.1, < 1.0.0 |

### Modules
Expand Down
169 changes: 46 additions & 123 deletions security_group.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,138 +64,61 @@ locals {
}
}

resource "ibm_is_security_group_rule" "security_group_rules" {
for_each = local.security_group_rules
group = ibm_is_security_group.security_group[each.value.sg_name].id
direction = each.value.direction
remote = each.value.source
local = each.value.local
ip_version = each.value.ip_version


##############################################################################
# Dynamically create ICMP Block
##############################################################################

dynamic "icmp" {

# Runs a for each loop, if the rule block contains icmp, it looks through the block
# Otherwise the list will be empty

for_each = (
# Only allow creation of icmp rules if all of the keys are not null.
# This allows the use of the optional variable in landing zone patterns
# to convert to a single typed list by adding `null` as the value.
each.value.icmp == null
? []
: length([
for value in ["type", "code"] :
true if lookup(each.value["icmp"], value, null) == null
]) == 2
? [] # if all values null empty array
: [each.value]
locals {
# True when tcp block has at least one non-null port value
sg_rule_has_tcp = {
for k, v in local.security_group_rules : k => (
v.tcp != null &&
length([for x in ["port_min", "port_max"] : true if lookup(v["tcp"], x, null) != null]) > 0
)
# Conditionally add content if sg has icmp
content {
type = lookup(
each.value["icmp"],
"type",
null
)
code = lookup(
each.value["icmp"],
"code",
null
)
}
}

##############################################################################

##############################################################################
# Dynamically create TCP Block
##############################################################################

dynamic "tcp" {

# Runs a for each loop, if the rule block contains tcp, it looks through the block
# Otherwise the list will be empty

for_each = (
# Only allow creation of tcp rules if all of the keys are not null.
# This allows the use of the optional variable in landing zone patterns
# to convert to a single typed list by adding `null` as the value.
# the default behavior will be to set `null` `port_min` values to 1 if null
# and `port_max` to 65535 if null
each.value.tcp == null
? []
: length([
for value in ["port_min", "port_max"] :
true if lookup(each.value["tcp"], value, null) == null
]) == 2
? [] # if all values null empty array
: [each.value]
# True when udp block has at least one non-null port value
sg_rule_has_udp = {
for k, v in local.security_group_rules : k => (
v.udp != null &&
length([for x in ["port_min", "port_max"] : true if lookup(v["udp"], x, null) != null]) > 0
)

# Conditionally adds content if sg has tcp
content {
port_min = lookup(
each.value["tcp"],
"port_min",
null
)

port_max = lookup(
each.value["tcp"],
"port_max",
null
)
}
}

##############################################################################

##############################################################################
# Dynamically create UDP Block
##############################################################################

dynamic "udp" {

# Runs a for each loop, if the rule block contains udp, it looks through the block
# Otherwise the list will be empty

for_each = (
# Only allow creation of udp rules if all of the keys are not null.
# This allows the use of the optional variable in landing zone patterns
# to convert to a single typed list by adding `null` as the value.
# the default behavior will be to set `null` `port_min` values to 1 if null
# and `port_max` to 65535 if null
each.value.udp == null
? []
: length([
for value in ["port_min", "port_max"] :
true if lookup(each.value["udp"], value, null) == null
]) == 2
? [] # if all values null empty array
: [each.value]
# True when icmp block has at least one non-null type/code value
sg_rule_has_icmp = {
for k, v in local.security_group_rules : k => (
v.icmp != null &&
length([for x in ["type", "code"] : true if lookup(v["icmp"], x, null) != null]) > 0
)

# Conditionally adds content if sg has udp
content {
port_min = lookup(
each.value["udp"],
"port_min",
null
)
port_max = lookup(
each.value["udp"],
"port_max",
null
)
}
}
}

resource "ibm_is_security_group_rule" "security_group_rules" {
for_each = local.security_group_rules
group = ibm_is_security_group.security_group[each.value.sg_name].id
direction = each.value.direction
remote = each.value.source
local = each.value.local
ip_version = each.value.ip_version

##############################################################################
protocol = (
local.sg_rule_has_tcp[each.key] ? "tcp" :
local.sg_rule_has_udp[each.key] ? "udp" :
local.sg_rule_has_icmp[each.key] ? "icmp" :
null
)

port_min = (
local.sg_rule_has_tcp[each.key] ? lookup(each.value["tcp"], "port_min", null) :
local.sg_rule_has_udp[each.key] ? lookup(each.value["udp"], "port_min", null) :
null
)

port_max = (
local.sg_rule_has_tcp[each.key] ? lookup(each.value["tcp"], "port_max", null) :
local.sg_rule_has_udp[each.key] ? lookup(each.value["udp"], "port_max", null) :
null
)

type = local.sg_rule_has_icmp[each.key] ? lookup(each.value["icmp"], "type", null) : null
code = local.sg_rule_has_icmp[each.key] ? lookup(each.value["icmp"], "code", null) : null

}

Expand Down
2 changes: 1 addition & 1 deletion version.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ terraform {
# Use "greater than or equal to" range in modules
ibm = {
source = "IBM-Cloud/ibm"
version = ">= 1.78.4, < 2.0.0"
version = ">= 1.87.3, < 2.0.0"
}
time = {
source = "hashicorp/time"
Expand Down