Skip to content

Conversation

@onufer
Copy link
Member

@onufer onufer commented Dec 13, 2024

What is the change?

Stop checking if its the last node since this often breaks for snapshots and just calculate reactivity swing at all nodes.

Why is the change being made?

If you do snapshot and don't have cycles and nodes consistent, you get an error.

Cycles and nodes don't have meaning for snapshots, so it is probably best to not force this and calculate partial cycle reactivity swing.

see #2034

SCR Information

Change Type: features

One-Sentence Description: Stop checking if its the last node since this often breaks for snapshots and just calculate reactivity swing at all nodes.

One-line Impact on Requirements: NA


Checklist

@onufer onufer requested a review from mgjarrett December 13, 2024 20:21
@john-science john-science added the feature request Smaller user request label Mar 14, 2025
@john-science john-science changed the title reactivity swing Stop checking for last node in Snapshots Mar 14, 2025
@github-actions
Copy link

This pull request has been automatically marked as stale because it has not had any activity in the last 100 days. It will be closed in 7 days if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale Inactive PRs cannot be open forever label Jun 23, 2025
@github-actions github-actions bot closed this Jul 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature request Smaller user request stale Inactive PRs cannot be open forever

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants