Skip to content

add wxc unit test plus two fixes #556

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 11 commits into
base: main
Choose a base branch
from
Open

add wxc unit test plus two fixes #556

wants to merge 11 commits into from

Conversation

@romeokienzler
Copy link
Collaborator

No description provided.

@romeokienzler romeokienzler force-pushed the rkie_improve_test_coverage branch from b0ef1f7 to 151b575 Compare March 28, 2025 16:01
@romeokienzler romeokienzler self-assigned this Mar 28, 2025
@romeokienzler romeokienzler force-pushed the rkie_improve_test_coverage branch from e2067ec to 40bf6da Compare April 14, 2025 12:48
romeokienzler and others added 4 commits April 16, 2025 02:43
@romeokienzler
add Dockerfile
233a1db 
Signed-off-by: Romeo Kienzler <[email protected]>
@romeokienzler
add wxc integration test plus two fixes
57588f2 
Signed-off-by: Romeo Kienzler <[email protected]>
@romeokienzler
fix test
2a0d8a2 
Signed-off-by: Romeo Kienzler <[email protected]>
@Joao-L-S-Almeida @romeokienzler
Removing test for None
eaae569 
Signed-off-by: João Lucas de Sousa Almeida <[email protected]>
Signed-off-by: Romeo Kienzler <[email protected]>
@romeokienzler romeokienzler force-pushed the rkie_improve_test_coverage branch from 3815bed to eaae569 Compare April 16, 2025 06:45
@romeokienzler
Copy link
Collaborator Author

@Joao-L-S-Almeida cn u pse review, tests are passing

jbsub -q x86_1h -mem 48G -cores 1x2 -interactive 'pytest tests/test_prithvi_wxc_model_factory.py'

@romeokienzler
Copy link
Collaborator Author

@Joao-L-S-Almeida saying they are failing for github

@romeokienzler
Copy link
Collaborator Author

moving those tests to /integrationtests (to run on IBM Research CCC) as they require too much resources/disk/time to downloads

@romeokienzler romeokienzler added 1.1 and removed 1.0.2 labels May 15, 2025
@romeokienzler romeokienzler added 1.2 and removed 1.1 labels May 28, 2025
@Joao-L-S-Almeida
Copy link
Collaborator

One test is still failing with error:
tests/test_prithvi_wxc_model_factory.py::test_wxc_unet_pincer_inference [Gloo] Rank 0 is connected to 0 peer ranks. Expected number of connected peer ranks is : 0
Something we need to change in the Actions config ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@romeokienzler romeokienzler

Labels

1.2

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@romeokienzler @Joao-L-S-Almeida