TimeSlider / TimeLayerSliderPanel: Pass value correctly to layer / component and use DayJs#4175
Merged
ahennr merged 6 commits intoterrestris:mainfrom Jan 24, 2025
Merged
Conversation
BREAKING CHANGE: MomentJS is replaced by DayJS
LukasLohoff
approved these changes
Jan 23, 2025
Member
LukasLohoff
left a comment
There was a problem hiding this comment.
Very nice!
Shouldn't we also add dayjs to the package.json?
hwbllmnn
approved these changes
Jan 24, 2025
Member
Author
Is not needed IHMO since its a transitive dependency of |
dnlkoch
approved these changes
Jan 24, 2025
Member
|
🎉 This PR is included in version 28.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR refactors the
TimeSliderandTimeLayerSliderPanelcomponents to allow the time value to be updated externally (e.g., through aForm) and passed directly to configured time layers. Additionally,momentjshas been replaced withdayjs, aligning with the default time library used inantd.With these changes, there are now two ways to retrieve the selected value from the slider:
onChange: Triggered immediately when the slider's value changes.onChangeComplete: Triggered once the user finishes dragging the slider pointer.Related issues or pull requests
Pull request type
Do you introduce a breaking change?
Checklist
BSD-2-Clause.
npm run checklocally).