feat: add service mode to webview and reduce log when car is Unlocked at service mode#5289
Open
NirKli wants to merge 4 commits into
Open
feat: add service mode to webview and reduce log when car is Unlocked at service mode#5289NirKli wants to merge 4 commits into
Unlocked at service mode#5289NirKli wants to merge 4 commits into
Conversation
✅ Deploy Preview for teslamate ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
|
NirKli
changed the title
Unlocked at service mode
Collaborator
|
I imagine this might (?) conflict with #4453. Shouldn't be hard to resolve either way, just wanted to flag this as a possible issue. |
JakobLichterfeld
changed the title
Unlocked at service modeUnlocked at service mode
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add service mode support and reduce
Unlockedlog noiseDescription
TeslaMate currently logs repeated
[warning] Unlockedmessages at a high frequency (~every 30 seconds) when the vehicle remains unlocked.This becomes especially noisy when the vehicle is in service mode, where it is expected to stay unlocked for extended periods.
Changes
service_modefield toTeslaApi.Vehicle.State(parsed from Tesla API)Unlockedwarning logs whenservice_mode = trueBehavior
Unlockedwarnings are logged normally when not in service modeservice_modeis enabled, repeated logs are suppressed to avoid noiseScreenshots