Clean up QoS settings #123
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
rjoomen
commented
Oct 1, 2024
rjoomen
commented
- Replace deprecated rmw_qos_profile_* profiles by their newer rclcpp counterparts.
- Use SensorDataQoS() for joint state subscriptions.
- Increase history depth for plotting (with a history of 1, the Workbench missed planning results when sent too quickly).
- Some other replacements to defaults or matching profiles.
marip8
reviewed
Oct 1, 2024
Contributor
|
This looks good to me, but seems like it doesn't work with humble and foxy |
Contributor
Author
Yes, I'm planning to fix this. Something in the API changed, unfortunately. |
- Add RCLCPP_VERSION_GTE macro for older ROS versions - Use RCLCPP_VERSION_GTE instead of header check to determine Humble
Contributor
Author
|
Pending tesseract-robotics/tesseract_ros#251 for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.