Direct upload flow documentation improvements - #27
Merged
danielvysotskyi merged 1 commit intoNov 12, 2025
Conversation
aleksei-okatiev
approved these changes
Nov 11, 2025
garciaf
reviewed
Nov 11, 2025
| { | ||
| "binary_app_id": 123, | ||
| "url": "https://upload.test.io/direct", | ||
| "url": "https://my-bucket.s3.eu-west-1.amazonaws.com", |
Member
There was a problem hiding this comment.
This is the url that a user will get?
Contributor
Author
There was a problem hiding this comment.
yes that is upload url for S3, that is direct upload to S3 that bypass our infrastructure so here will be AWS link not ours
also that is a reason why we should do 3-rd step with metadata for carierwave that connects each step and provide public url for download
Contributor
Author
There was a problem hiding this comment.
Our part here are signature attribute and policy where we provide limitation for upload.
all those fields that we returns with presigned url like a signature for document, that like tell AWS "yes you can allow upload this time, here you have my signature as proof"
garciaf
approved these changes
Nov 12, 2025
danielvysotskyi
deleted the
binary_apps/presigned_link_flow_improvements
branch
November 12, 2025 11:50
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds more deatailed explanation for GET Presigned link resonse attributes and for PUT Update existed binary app request and response attributes. Also this PR add changes to GET and PUT request attributes that represent changes in backend logic.