Skip to content

[Test] Migrate voiceservices to TypeSpec #3098

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 29 commits into
base: main
Choose a base branch
from
Open

Conversation

ankhyk
Copy link

@ankhyk ankhyk commented Nov 30, 2023

ARM (Control Plane) API Specification Update Pull Request

PR review workflow diagram

Please understand this diagram before proceeding. It explains how to get your PR approved & merged.

diagram

[1] ARM review queue (for merge queues, see [4])
The PRs are processed by time opened, ascending. Your PR may show up on 2nd or later page.
If you addressed Step 1 from the diagram and your PR is not showing up in the queue, ensure the label ARMChangesRequested
is removed from your PR. This should cause the label WaitForARMFeedback to be added.
[2] https://aka.ms/azsdk/support/specreview-channel
[3] List of SDK breaking changes approvers in pinned Teams announcement
[4] public repo merge queue, private repo merge queue (for ARM review queue, [1])

If you need further help with anything, see Getting help section below.

Purpose of this PR

What's the purpose of this PR? Check all that apply. This is mandatory!

  • New API version. (If API spec is not defined in TypeSpec, the PR should have been generated using OpenAPI Hub).
  • Update existing version for a new feature. (This is applicable only when you are revising a private preview API version.)
  • Update existing version to fix swagger quality issues in S360.
  • Other, please clarify:
    • edit this with your clarification

Due diligence checklist

To merge this PR, you must go through the following checklist and confirm you understood
and followed the instructions by checking all the boxes:

Breaking changes review (Step 1)

  • If the automation determines you have breaking changes, i.e. Step 1 from the diagram applies to you,
    you must follow the breaking changes process.
    IMPORTANT This applies even if:
    • The tool fails while it shouldn't, e.g. due to runtime exception, or incorrect detection of breaking changes.
    • You believe there is no need for you to request breaking change approval, for any reason.
      Such claims must be reviewed, and the process is the same.

ARM API changes review (Step 2)

  • If this PR is in purview of ARM review then automation will add the ARMReview label.
  • If you want to force ARM review, add the label yourself.
  • Proceed according to the diagram at the top of this comment.

Viewing API changes

For convenient view of the API changes made by this PR, refer to the URLs provided in the table
in the Generated ApiView comment added to this PR. You can use ApiView to show API versions diff.

Suppressing failures

If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the
Swagger-Suppression-Process
to get approval.

Getting help

raych1 and others added 28 commits September 13, 2023 06:39
* Rename bug.md to bug_report.md

* Create config.yml
[Internal testing] testing openapi-alps PR 510778 - Test 11/14/2023 / 1
[Internal testing] testing openapi-alps PR 510778 - Test 11/14/2023 / 2
[Internal testing] testing openapi-alps PR 510778 - Test 11/15/2023 / 1
[Internal testing] testing openapi-alps PR 511346 - Test 1
Copy link

openapi-pipeline-app-test bot commented Nov 30, 2023

Next Steps to merge

Next steps that must be taken to merge this PR:
  • ❌ Your PR is in purview of ARM review (label: ARMReview). Please ensure your PR is on the ARM PR review queue - see instructions in steps 1 and 2 in the PR description diagram.
  • ❌ The required check named Automated merging requirements met has failed. This is the final check that must pass. Refer to the check in the PR's 'Checks' tab for details on how to fix it. In addition, refer to step 4 in the PR workflow diagram (even if your PR is for data plane, not ARM).

Copy link

openapi-pipeline-app-test bot commented Nov 30, 2023

Swagger Generation Artifacts

️🔄~[NotRequired_Staging] ApiDocPreview inProgress [Detail]
️⚠️ azure-sdk-for-python-track2 warning [Detail]
  • ⚠️Warning [Logs] Generate from a9d6a54ec293188df637caf6e7b0dadbadf90dfd. SDK Automation 14.0.0
    command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
    cmderr	[automation_init.sh] WARNING: azure-devtools 1.2.1 does not provide the extra 'ci-tools'
    cmderr	[automation_init.sh] WARNING: azure-devtools 1.2.1 does not provide the extra 'ci-tools'
    cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
    command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
    cmderr	[automation_generate.sh]
    cmderr	[automation_generate.sh] npm notice New major version of npm available! 9.8.1 -> 10.2.4
    cmderr	[automation_generate.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v10.2.4>
    cmderr	[automation_generate.sh] npm notice Run `npm install -g [email protected]` to update!
    cmderr	[automation_generate.sh] npm notice
  • ️✔️track2_azure-mgmt-voiceservices [View full logs]  [Preview SDK Changes]
    info	[Changelog] ### Features Added
    info	[Changelog]
    info	[Changelog]   - Model CommunicationsGateway has a new parameter allocated_media_address_prefixes
    info	[Changelog]   - Model CommunicationsGateway has a new parameter allocated_signaling_address_prefixes
    info	[Changelog]   - Model CommunicationsGateway has a new parameter custom_sip_headers
    info	[Changelog]   - Model CommunicationsGateway has a new parameter dns_delegations
    info	[Changelog]   - Model CommunicationsGateway has a new parameter identity
    info	[Changelog]   - Model CommunicationsGateway has a new parameter integrated_mcp_enabled
    info	[Changelog]   - Model CommunicationsGateway has a new parameter sku
    info	[Changelog]   - Model CommunicationsGatewayUpdate has a new parameter identity
    info	[Changelog]   - Model CommunicationsGatewayUpdate has a new parameter sku
️⚠️ azure-sdk-for-java warning [Detail]
  • ⚠️Warning [Logs] Generate from a9d6a54ec293188df637caf6e7b0dadbadf90dfd. SDK Automation 14.0.0
    command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
    cmderr	[init.sh] [notice] A new release of pip is available: 23.0.1 -> 23.3.1
    cmderr	[init.sh] [notice] To update, run: pip install --upgrade pip
    cmderr	[init.sh] [notice] A new release of pip is available: 23.0.1 -> 23.3.1
    cmderr	[init.sh] [notice] To update, run: pip install --upgrade pip
    command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json
  • ️✔️azure-resourcemanager-voiceservices [View full logs]  [Preview SDK Changes]
️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]
  • ️✔️Succeeded [Logs] Generate from a9d6a54ec293188df637caf6e7b0dadbadf90dfd. SDK Automation 14.0.0
    command	sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
    command	generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
  • ️✔️sdk/resourcemanager/voiceservices/armvoiceservices [View full logs]  [Preview SDK Changes] Breaking Change Detected
    info	[Changelog] ### Breaking Changes
    info	[Changelog]
    info	[Changelog] - Type of `CommunicationsGatewayProperties.APIBridge` has been changed from `any` to `*APIBridgeProperties`
    info	[Changelog]
    info	[Changelog] ### Features Added
    info	[Changelog]
    info	[Changelog] - New value `CommunicationsPlatformTeamsDirectRouting` added to enum type `CommunicationsPlatform`
    info	[Changelog] - New enum type `APIBridgeActivationState` with values `APIBridgeActivationStateDisabled`, `APIBridgeActivationStateEnabled`
    info	[Changelog] - New enum type `ManagedServiceIdentityType` with values `ManagedServiceIdentityTypeNone`, `ManagedServiceIdentityTypeSystemAssigned`, `ManagedServiceIdentityTypeSystemAssignedUserAssigned`, `ManagedServiceIdentityTypeUserAssigned`
    info	[Changelog] - New enum type `SKUTier` with values `SKUTierBasic`, `SKUTierFree`, `SKUTierPremium`, `SKUTierStandard`
    info	[Changelog] - New struct `APIBridgeProperties`
    info	[Changelog] - New struct `CustomSipHeader`
    info	[Changelog] - New struct `CustomSipHeadersProperties`
    info	[Changelog] - New struct `DNSDelegationProperties`
    info	[Changelog] - New struct `DNSDelegationsProperties`
    info	[Changelog] - New struct `ManagedServiceIdentity`
    info	[Changelog] - New struct `SKU`
    info	[Changelog] - New struct `UserAssignedIdentity`
    info	[Changelog] - New field `Identity`, `SKU` in struct `CommunicationsGateway`
    info	[Changelog] - New field `AllocatedMediaAddressPrefixes`, `AllocatedSignalingAddressPrefixes`, `CustomSipHeaders`, `DNSDelegations`, `IntegratedMcpEnabled` in struct `CommunicationsGatewayProperties`
    info	[Changelog] - New field `Identity`, `SKU` in struct `CommunicationsGatewayUpdate`
    info	[Changelog]
    info	[Changelog] Total 1 breaking change(s), 33 additive change(s).
️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]
  • ️✔️Succeeded [Logs] Generate from a9d6a54ec293188df637caf6e7b0dadbadf90dfd. SDK Automation 14.0.0
    command	sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json
    warn	File azure-sdk-for-js_tmp/initOutput.json not found to read
    command	sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json
  • ️✔️@azure/arm-voiceservices [View full logs]  [Preview SDK Changes] Breaking Change Detected
    info	[Changelog] **Features**
    info	[Changelog]
    info	[Changelog]   - Added Interface ApiBridgeProperties
    info	[Changelog]   - Added Interface CustomSipHeader
    info	[Changelog]   - Added Interface CustomSipHeadersProperties
    info	[Changelog]   - Added Interface DnsDelegationProperties
    info	[Changelog]   - Added Interface DnsDelegationsProperties
    info	[Changelog]   - Added Interface ManagedServiceIdentity
    info	[Changelog]   - Added Interface Sku
    info	[Changelog]   - Added Interface UserAssignedIdentity
    info	[Changelog]   - Added Type Alias ApiBridgeActivationState
    info	[Changelog]   - Added Type Alias ManagedServiceIdentityType
    info	[Changelog]   - Added Type Alias SkuTier
    info	[Changelog]   - Interface CommunicationsGateway has a new optional parameter allocatedMediaAddressPrefixes
    info	[Changelog]   - Interface CommunicationsGateway has a new optional parameter allocatedSignalingAddressPrefixes
    info	[Changelog]   - Interface CommunicationsGateway has a new optional parameter customSipHeaders
    info	[Changelog]   - Interface CommunicationsGateway has a new optional parameter dnsDelegations
    info	[Changelog]   - Interface CommunicationsGateway has a new optional parameter identity
    info	[Changelog]   - Interface CommunicationsGateway has a new optional parameter integratedMcpEnabled
    info	[Changelog]   - Interface CommunicationsGateway has a new optional parameter sku
    info	[Changelog]   - Interface CommunicationsGatewaysDeleteHeaders has a new optional parameter location
    info	[Changelog]   - Interface CommunicationsGatewayUpdate has a new optional parameter identity
    info	[Changelog]   - Interface CommunicationsGatewayUpdate has a new optional parameter sku
    info	[Changelog]   - Interface TestLinesDeleteHeaders has a new optional parameter location
    info	[Changelog]   - Added Enum KnownApiBridgeActivationState
    info	[Changelog]   - Added Enum KnownManagedServiceIdentityType
    info	[Changelog]   - Enum KnownCommunicationsPlatform has a new value TeamsDirectRouting
    info	[Changelog]
    info	[Changelog] **Breaking Changes**
    info	[Changelog]
    info	[Changelog]   - Type of parameter apiBridge of interface CommunicationsGateway is changed from Record<string, unknown> to ApiBridgeProperties
️❌ azure-sdk-for-net-track2 failed [Detail]
  • Failed [Logs] Generate from a9d6a54ec293188df637caf6e7b0dadbadf90dfd. SDK Automation 14.0.0
    command	pwsh ./eng/scripts/Automation-Sdk-Init.ps1 ../azure-sdk-for-net_tmp/initInput.json ../azure-sdk-for-net_tmp/initOutput.json
    command	pwsh ./eng/scripts/Invoke-GenerateAndBuildV2.ps1 ../azure-sdk-for-net_tmp/generateInput.json ../azure-sdk-for-net_tmp/generateOutput.json
    cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1mGeneratePackage: �[0m/mnt/vss/_work/1/s/azure-sdk-for-net/eng/scripts/automation/GenerateAndBuildLib.ps1:714
    cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1mLine |
    cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1m 714 | �[0m         �[36;1mGeneratePackage -projectFolder $projectFolder -sdkRootPath $s�[0m …
    cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1m     | �[31;1m         ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1m�[36;1m     | �[31;1mFailed to build sdk. exit code: False
    cmderr	[Invoke-GenerateAndBuildV2.ps1] �[0m
    cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1mGeneratePackage: �[0m/mnt/vss/_work/1/s/azure-sdk-for-net/eng/scripts/automation/GenerateAndBuildLib.ps1:714
    cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1mLine |
    cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1m 714 | �[0m         �[36;1mGeneratePackage -projectFolder $projectFolder -sdkRootPath $s�[0m …
    cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1m     | �[31;1m         ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1m�[36;1m     | �[31;1mFailed to packe sdk. exit code: False
    cmderr	[Invoke-GenerateAndBuildV2.ps1] �[0m
    cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1mGet-ChildItem: �[0m/mnt/vss/_work/1/s/azure-sdk-for-net/eng/scripts/automation/GenerateAndBuildLib.ps1:807
    cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1mLine |
    cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1m 807 | �[0m … rtifacts += �[36;1mGet-ChildItem $artifactsPath -Filter *.nupkg -exclude *.s�[0m …
    cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1m     | �[31;1m               ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1m�[36;1m     | �[31;1mCannot find path
    cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1m     | �[31;1m'/mnt/vss/_work/1/s/azure-sdk-for-net/artifacts/packages/Debug/' because
    cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1m     | �[31;1mit does not exist.
    cmderr	[Invoke-GenerateAndBuildV2.ps1] �[0m
    cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1mGeneratePackage: �[0m/mnt/vss/_work/1/s/azure-sdk-for-net/eng/scripts/automation/GenerateAndBuildLib.ps1:714
    cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1mLine |
    cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1m 714 | �[0m         �[36;1mGeneratePackage -projectFolder $projectFolder -sdkRootPath $s�[0m …
    cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1m     | �[31;1m         ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1m�[36;1m     | �[31;1mFailed to generate sdk artifact
    cmderr	[Invoke-GenerateAndBuildV2.ps1] �[0m
  • Azure.ResourceManager.VoiceServices [View full logs]  [Preview SDK Changes] Breaking Change Detected
    info	[Changelog] Breaking Changes: /home/cloudtest/.nuget/packages/microsoft.dotnet.apicompat/5.0.0-beta.20467.1/build/Microsoft.DotNet.ApiCompat.targets(82,5): error : TypesMustExist : Type 'Azure.ResourceManager.VoiceServices.VoiceServicesCommunicationsGatewayResource' does not exist in the implementation but it does exist in the contract. [/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/voiceservices/Azure.ResourceManager.VoiceServices/src/Azure.ResourceManager.VoiceServices.csproj::TargetFramework=netstandard2.0],
    info	[Changelog] /home/cloudtest/.nuget/packages/microsoft.dotnet.apicompat/5.0.0-beta.20467.1/build/Microsoft.DotNet.ApiCompat.targets(82,5): error : TypesMustExist : Type 'Azure.ResourceManager.VoiceServices.VoiceServicesExtensions' does not exist in the implementation but it does exist in the contract. [/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/voiceservices/Azure.ResourceManager.VoiceServices/src/Azure.ResourceManager.VoiceServices.csproj::TargetFramework=netstandard2.0],
    info	[Changelog] /home/cloudtest/.nuget/packages/microsoft.dotnet.apicompat/5.0.0-beta.20467.1/build/Microsoft.DotNet.ApiCompat.targets(82,5): error : TypesMustExist : Type 'Azure.ResourceManager.VoiceServices.VoiceServicesTestLineCollection' does not exist in the implementation but it does exist in the contract. [/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/voiceservices/Azure.ResourceManager.VoiceServices/src/Azure.ResourceManager.VoiceServices.csproj::TargetFramework=netstandard2.0],
    info	[Changelog] /home/cloudtest/.nuget/packages/microsoft.dotnet.apicompat/5.0.0-beta.20467.1/build/Microsoft.DotNet.ApiCompat.targets(82,5): error : TypesMustExist : Type 'Azure.ResourceManager.VoiceServices.VoiceServicesTestLineData' does not exist in the implementation but it does exist in the contract. [/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/voiceservices/Azure.ResourceManager.VoiceServices/src/Azure.ResourceManager.VoiceServices.csproj::TargetFramework=netstandard2.0],
    info	[Changelog] /home/cloudtest/.nuget/packages/microsoft.dotnet.apicompat/5.0.0-beta.20467.1/build/Microsoft.DotNet.ApiCompat.targets(82,5): error : TypesMustExist : Type 'Azure.ResourceManager.VoiceServices.VoiceServicesTestLineResource' does not exist in the implementation but it does exist in the contract. [/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/voiceservices/Azure.ResourceManager.VoiceServices/src/Azure.ResourceManager.VoiceServices.csproj::TargetFramework=netstandard2.0],
    info	[Changelog] /home/cloudtest/.nuget/packages/microsoft.dotnet.apicompat/5.0.0-beta.20467.1/build/Microsoft.DotNet.ApiCompat.targets(82,5): error : TypesMustExist : Type 'Azure.ResourceManager.VoiceServices.Models.ArmVoiceServicesModelFactory' does not exist in the implementation but it does exist in the contract. [/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/voiceservices/Azure.ResourceManager.VoiceServices/src/Azure.ResourceManager.VoiceServices.csproj::TargetFramework=netstandard2.0],
    info	[Changelog] /home/cloudtest/.nuget/packages/microsoft.dotnet.apicompat/5.0.0-beta.20467.1/build/Microsoft.DotNet.ApiCompat.targets(82,5): error : TypesMustExist : Type 'Azure.ResourceManager.VoiceServices.Models.VoiceServicesAutoGeneratedDomainNameLabelScope' does not exist in the implementation but it does exist in the contract. [/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/voiceservices/Azure.ResourceManager.VoiceServices/src/Azure.ResourceManager.VoiceServices.csproj::TargetFramework=netstandard2.0],
    info	[Changelog] /home/cloudtest/.nuget/packages/microsoft.dotnet.apicompat/5.0.0-beta.20467.1/build/Microsoft.DotNet.ApiCompat.targets(82,5): error : TypesMustExist : Type 'Azure.ResourceManager.VoiceServices.Models.VoiceServicesCheckNameAvailabilityContent' does not exist in the implementation but it does exist in the contract. [/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/voiceservices/Azure.ResourceManager.VoiceServices/src/Azure.ResourceManager.VoiceServices.csproj::TargetFramework=netstandard2.0],
    info	[Changelog] /home/cloudtest/.nuget/packages/microsoft.dotnet.apicompat/5.0.0-beta.20467.1/build/Microsoft.DotNet.ApiCompat.targets(82,5): error : TypesMustExist : Type 'Azure.ResourceManager.VoiceServices.Models.VoiceServicesCheckNameAvailabilityResult' does not exist in the implementation but it does exist in the contract. [/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/voiceservices/Azure.ResourceManager.VoiceServices/src/Azure.ResourceManager.VoiceServices.csproj::TargetFramework=netstandard2.0],
    info	[Changelog] /home/cloudtest/.nuget/packages/microsoft.dotnet.apicompat/5.0.0-beta.20467.1/build/Microsoft.DotNet.ApiCompat.targets(82,5): error : TypesMustExist : Type 'Azure.ResourceManager.VoiceServices.Models.VoiceServicesCommunicationsGatewayConnectivity' does not exist in the implementation but it does exist in the contract. [/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/voiceservices/Azure.ResourceManager.VoiceServices/src/Azure.ResourceManager.VoiceServices.csproj::TargetFramework=netstandard2.0],
    info	[Changelog] /home/cloudtest/.nuget/packages/microsoft.dotnet.apicompat/5.0.0-beta.20467.1/build/Microsoft.DotNet.ApiCompat.targets(82,5): error : TypesMustExist : Type 'Azure.ResourceManager.VoiceServices.Models.VoiceServicesCommunicationsGatewayPatch' does not exist in the implementation but it does exist in the contract. [/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/voiceservices/Azure.ResourceManager.VoiceServices/src/Azure.ResourceManager.VoiceServices.csproj::TargetFramework=netstandard2.0],
    info	[Changelog] /home/cloudtest/.nuget/packages/microsoft.dotnet.apicompat/5.0.0-beta.20467.1/build/Microsoft.DotNet.ApiCompat.targets(82,5): error : TypesMustExist : Type 'Azure.ResourceManager.VoiceServices.Models.VoiceServicesCommunicationsGatewayStatus' does not exist in the implementation but it does exist in the contract. [/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/voiceservices/Azure.ResourceManager.VoiceServices/src/Azure.ResourceManager.VoiceServices.csproj::TargetFramework=netstandard2.0],
    info	[Changelog] /home/cloudtest/.nuget/packages/microsoft.dotnet.apicompat/5.0.0-beta.20467.1/build/Microsoft.DotNet.ApiCompat.targets(82,5): error : TypesMustExist : Type 'Azure.ResourceManager.VoiceServices.Models.VoiceServicesCommunicationsPlatform' does not exist in the implementation but it does exist in the contract. [/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/voiceservices/Azure.ResourceManager.VoiceServices/src/Azure.ResourceManager.VoiceServices.csproj::TargetFramework=netstandard2.0],
    info	[Changelog] /home/cloudtest/.nuget/packages/microsoft.dotnet.apicompat/5.0.0-beta.20467.1/build/Microsoft.DotNet.ApiCompat.targets(82,5): error : TypesMustExist : Type 'Azure.ResourceManager.VoiceServices.Models.VoiceServicesEmergencyCallType' does not exist in the implementation but it does exist in the contract. [/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/voiceservices/Azure.ResourceManager.VoiceServices/src/Azure.ResourceManager.VoiceServices.csproj::TargetFramework=netstandard2.0],
    info	[Changelog] /home/cloudtest/.nuget/packages/microsoft.dotnet.apicompat/5.0.0-beta.20467.1/build/Microsoft.DotNet.ApiCompat.targets(82,5): error : TypesMustExist : Type 'Azure.ResourceManager.VoiceServices.Models.VoiceServicesNameUnavailableReason' does not exist in the implementation but it does exist in the contract. [/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/voiceservices/Azure.ResourceManager.VoiceServices/src/Azure.ResourceManager.VoiceServices.csproj::TargetFramework=netstandard2.0],
    info	[Changelog] /home/cloudtest/.nuget/packages/microsoft.dotnet.apicompat/5.0.0-beta.20467.1/build/Microsoft.DotNet.ApiCompat.targets(82,5): error : TypesMustExist : Type 'Azure.ResourceManager.VoiceServices.Models.VoiceServicesPrimaryRegionProperties' does not exist in the implementation but it does exist in the contract. [/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/voiceservices/Azure.ResourceManager.VoiceServices/src/Azure.ResourceManager.VoiceServices.csproj::TargetFramework=netstandard2.0],
    info	[Changelog] /home/cloudtest/.nuget/packages/microsoft.dotnet.apicompat/5.0.0-beta.20467.1/build/Microsoft.DotNet.ApiCompat.targets(82,5): error : TypesMustExist : Type 'Azure.ResourceManager.VoiceServices.Models.VoiceServicesProvisioningState' does not exist in the implementation but it does exist in the contract. [/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/voiceservices/Azure.ResourceManager.VoiceServices/src/Azure.ResourceManager.VoiceServices.csproj::TargetFramework=netstandard2.0],
    info	[Changelog] /home/cloudtest/.nuget/packages/microsoft.dotnet.apicompat/5.0.0-beta.20467.1/build/Microsoft.DotNet.ApiCompat.targets(82,5): error : TypesMustExist : Type 'Azure.ResourceManager.VoiceServices.Models.VoiceServicesServiceRegionProperties' does not exist in the implementation but it does exist in the contract. [/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/voiceservices/Azure.ResourceManager.VoiceServices/src/Azure.ResourceManager.VoiceServices.csproj::TargetFramework=netstandard2.0],
    info	[Changelog] /home/cloudtest/.nuget/packages/microsoft.dotnet.apicompat/5.0.0-beta.20467.1/build/Microsoft.DotNet.ApiCompat.targets(82,5): error : TypesMustExist : Type 'Azure.ResourceManager.VoiceServices.Models.VoiceServicesTeamsCodec' does not exist in the implementation but it does exist in the contract. [/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/voiceservices/Azure.ResourceManager.VoiceServices/src/Azure.ResourceManager.VoiceServices.csproj::TargetFramework=netstandard2.0],
    info	[Changelog] /home/cloudtest/.nuget/packages/microsoft.dotnet.apicompat/5.0.0-beta.20467.1/build/Microsoft.DotNet.ApiCompat.targets(82,5): error : TypesMustExist : Type 'Azure.ResourceManager.VoiceServices.Models.VoiceServicesTestLinePatch' does not exist in the implementation but it does exist in the contract. [/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/voiceservices/Azure.ResourceManager.VoiceServices/src/Azure.ResourceManager.VoiceServices.csproj::TargetFramework=netstandard2.0],
    info	[Changelog] /home/cloudtest/.nuget/packages/microsoft.dotnet.apicompat/5.0.0-beta.20467.1/build/Microsoft.DotNet.ApiCompat.targets(82,5): error : TypesMustExist : Type 'Azure.ResourceManager.VoiceServices.Models.VoiceServicesTestLinePurpose' does not exist in the implementation but it does exist in the contract. [/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/voiceservices/Azure.ResourceManager.VoiceServices/src/Azure.ResourceManager.VoiceServices.csproj::TargetFramework=netstandard2.0],
    info	[Changelog] /home/cloudtest/.nuget/packages/microsoft.dotnet.apicompat/5.0.0-beta.20467.1/build/Microsoft.DotNet.ApiCompat.targets(96,5): error : ApiCompat failed for '/mnt/vss/_work/1/s/azure-sdk-for-net/artifacts/bin/Azure.ResourceManager.VoiceServices/Debug/netstandard2.0/Azure.ResourceManager.VoiceServices.dll' [/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/voiceservices/Azure.ResourceManager.VoiceServices/src/Azure.ResourceManager.VoiceServices.csproj::TargetFramework=netstandard2.0]
️❌ azure-resource-manager-schemas failed [Detail]
  • Failed [Logs] Generate from a9d6a54ec293188df637caf6e7b0dadbadf90dfd. Schema Automation 14.0.0
    command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
    cmderr	[initScript.sh] npm notice
    cmderr	[initScript.sh] npm notice New major version of npm available! 8.19.4 -> 10.2.4
    cmderr	[initScript.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v10.2.4>
    cmderr	[initScript.sh] npm notice Run `npm install -g [email protected]` to update!
    cmderr	[initScript.sh] npm notice
    warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
    command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json
  • voiceservices/resource-manager [View full logs]  [Preview Schema Changes]
️❌ azure-powershell failed [Detail]
  • Pipeline Framework Failed [Logs] Generate from a9d6a54ec293188df637caf6e7b0dadbadf90dfd. SDK Automation 14.0.0
    command	sh ./tools/SwaggerCI/init.sh ../azure-powershell_tmp/initInput.json ../azure-powershell_tmp/initOutput.json
    command	pwsh ./tools/SwaggerCI/psci.ps1 ../azure-powershell_tmp/generateInput.json ../azure-powershell_tmp/generateOutput.json
    SSL error: syscall failure: Broken pipe
    Error: SSL error: syscall failure: Broken pipe
  • ️✔️Az.voiceservices.DefaultTag [View full logs
    error	Fatal error: SSL error: syscall failure: Broken pipe
    error	The following packages are still pending:
    error		Az.voiceservices.DefaultTag
    error		Az.VoiceServices.Autorest
  • ⚠️Az.VoiceServices.Autorest
Posted by Swagger Pipeline | How to fix these errors?

Copy link

openapi-pipeline-app-test bot commented Nov 30, 2023

Generated ApiView

Language Package Name ApiView Link
Go sdk/resourcemanager/voiceservices/armvoiceservices There is no API change compared with the previous version
JavaScript @azure/arm-voiceservices There is no API change compared with the previous version
Java azure-resourcemanager-voiceservices There is no API change compared with the previous version
Swagger Microsoft.VoiceServices There is no API change compared with the previous version

Copy link

openapi-pipeline-app-test bot commented Nov 30, 2023

Swagger Validation Report

️️✔️BreakingChange succeeded [Detail] [Expand]
There are no breaking changes.
compared swaggers (via Oad v0.10.4)] new version base version
openapi.json 2022-12-01-preview(8fcfba4) 2022-12-01-preview(main)
voiceservices.json 2023-01-31(8fcfba4) 2023-01-31(main)
voiceservices.json 2023-04-03(8fcfba4) 2023-04-03(main)
️️✔️Breaking Change(Cross-Version) succeeded [Detail] [Expand]
There are no breaking changes.
️⚠️LintDiff: 0 Warnings warning [Detail]
compared tags (via openapi-validator v2.1.6) new version base version
package-2023-01-31 package-2023-01-31(8fcfba4) package-2023-01-31(main)
package-2023-04-03 package-2023-04-03(8fcfba4) package-2023-04-03(main)

The following errors/warnings exist before current PR submission:

Only 30 items are listed, please refer to log for more details.

Rule Message
DeleteResponseCodes Long-running delete operations must have responses with 202, 204 and default return codes. They also must have no other response codes.
Location: Microsoft.VoiceServices/stable/2023-01-31/voiceservices.json#L335
LroLocationHeader A 202 response should include an Location response header.
Location: Microsoft.VoiceServices/stable/2023-01-31/voiceservices.json#L366
DeleteResponseCodes Long-running delete operations must have responses with 202, 204 and default return codes. They also must have no other response codes.
Location: Microsoft.VoiceServices/stable/2023-01-31/voiceservices.json#L632
LroLocationHeader A 202 response should include an Location response header.
Location: Microsoft.VoiceServices/stable/2023-01-31/voiceservices.json#L671
DeleteResponseCodes Long-running delete operations must have responses with 202, 204 and default return codes. They also must have no other response codes.
Location: Microsoft.VoiceServices/stable/2023-04-03/voiceservices.json#L335
LroLocationHeader A 202 response should include an Location response header.
Location: Microsoft.VoiceServices/stable/2023-04-03/voiceservices.json#L366
DeleteResponseCodes Long-running delete operations must have responses with 202, 204 and default return codes. They also must have no other response codes.
Location: Microsoft.VoiceServices/stable/2023-04-03/voiceservices.json#L632
LroLocationHeader A 202 response should include an Location response header.
Location: Microsoft.VoiceServices/stable/2023-04-03/voiceservices.json#L671
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: Microsoft.VoiceServices/stable/2023-01-31/voiceservices.json#L61
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: Microsoft.VoiceServices/stable/2023-01-31/voiceservices.json#L68
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: Microsoft.VoiceServices/stable/2023-01-31/voiceservices.json#L74
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: Microsoft.VoiceServices/stable/2023-01-31/voiceservices.json#L97
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: Microsoft.VoiceServices/stable/2023-01-31/voiceservices.json#L100
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: Microsoft.VoiceServices/stable/2023-01-31/voiceservices.json#L113
⚠️ PostOperationIdContainsUrlVerb OperationId should contain the verb: 'checknameavailability' in:'NameAvailability_CheckLocal'. Consider updating the operationId
Location: Microsoft.VoiceServices/stable/2023-01-31/voiceservices.json#L129
⚠️ ParameterNotUsingCommonTypes Not using the common-types defined parameter 'location'.
Location: Microsoft.VoiceServices/stable/2023-01-31/voiceservices.json#L131
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: Microsoft.VoiceServices/stable/2023-01-31/voiceservices.json#L140
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: Microsoft.VoiceServices/stable/2023-01-31/voiceservices.json#L143
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: Microsoft.VoiceServices/stable/2023-01-31/voiceservices.json#L165
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: Microsoft.VoiceServices/stable/2023-01-31/voiceservices.json#L185
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: Microsoft.VoiceServices/stable/2023-01-31/voiceservices.json#L188
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: Microsoft.VoiceServices/stable/2023-01-31/voiceservices.json#L191
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: Microsoft.VoiceServices/stable/2023-01-31/voiceservices.json#L204
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: Microsoft.VoiceServices/stable/2023-01-31/voiceservices.json#L227
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: Microsoft.VoiceServices/stable/2023-01-31/voiceservices.json#L230
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: Microsoft.VoiceServices/stable/2023-01-31/voiceservices.json#L233
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: Microsoft.VoiceServices/stable/2023-01-31/voiceservices.json#L254
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: Microsoft.VoiceServices/stable/2023-01-31/voiceservices.json#L272
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: Microsoft.VoiceServices/stable/2023-01-31/voiceservices.json#L275
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: Microsoft.VoiceServices/stable/2023-01-31/voiceservices.json#L278
️️✔️~[NotRequired_Staging] Lint(RPaaS) succeeded [Detail] [Expand]
Validation passes for Lint(RPaaS).
️️✔️SwaggerAPIView succeeded [Detail] [Expand]
️️✔️TypeSpecAPIView succeeded [Detail] [Expand]
️️✔️CredScan succeeded [Detail] [Expand]
There is no credential detected.
️️✔️PoliCheck succeeded [Detail] [Expand]
Validation passed for PoliCheck.
️❌Avocado: 19 Errors, 0 Warnings failed [Detail]
Rule Message
NO_JSON_FILE_FOUND The JSON file is not found but it is referenced from the readme file.
readme: specification/voiceservices/resource-manager/readme.md
json: Microsoft.VoiceServices/preview/2022-12-01-preview/voiceservices.json
UNREFERENCED_JSON_FILE The example JSON file is not referenced from the swagger file.
readme: specification/voiceservices/resource-manager/readme.md
json: preview/2022-12-01-preview/examples/CommunicationsGateways_CreateOrUpdate.json
UNREFERENCED_JSON_FILE The example JSON file is not referenced from the swagger file.
readme: specification/voiceservices/resource-manager/readme.md
json: preview/2022-12-01-preview/examples/CommunicationsGateways_Delete.json
UNREFERENCED_JSON_FILE The example JSON file is not referenced from the swagger file.
readme: specification/voiceservices/resource-manager/readme.md
json: preview/2022-12-01-preview/examples/CommunicationsGateways_Get.json
UNREFERENCED_JSON_FILE The example JSON file is not referenced from the swagger file.
readme: specification/voiceservices/resource-manager/readme.md
json: preview/2022-12-01-preview/examples/CommunicationsGateways_ListByResourceGroup.json
UNREFERENCED_JSON_FILE The example JSON file is not referenced from the swagger file.
readme: specification/voiceservices/resource-manager/readme.md
json: preview/2022-12-01-preview/examples/CommunicationsGateways_ListBySubscription.json
UNREFERENCED_JSON_FILE The example JSON file is not referenced from the swagger file.
readme: specification/voiceservices/resource-manager/readme.md
json: preview/2022-12-01-preview/examples/CommunicationsGateways_Update.json
UNREFERENCED_JSON_FILE The example JSON file is not referenced from the swagger file.
readme: specification/voiceservices/resource-manager/readme.md
json: preview/2022-12-01-preview/examples/Contacts_CreateOrUpdate.json
UNREFERENCED_JSON_FILE The example JSON file is not referenced from the swagger file.
readme: specification/voiceservices/resource-manager/readme.md
json: preview/2022-12-01-preview/examples/Contacts_Delete.json
UNREFERENCED_JSON_FILE The example JSON file is not referenced from the swagger file.
readme: specification/voiceservices/resource-manager/readme.md
json: preview/2022-12-01-preview/examples/Contacts_Get.json
UNREFERENCED_JSON_FILE The example JSON file is not referenced from the swagger file.
readme: specification/voiceservices/resource-manager/readme.md
json: preview/2022-12-01-preview/examples/Contacts_ListByCommunicationsGateway.json
UNREFERENCED_JSON_FILE The example JSON file is not referenced from the swagger file.
readme: specification/voiceservices/resource-manager/readme.md
json: preview/2022-12-01-preview/examples/Contacts_Update.json
UNREFERENCED_JSON_FILE The example JSON file is not referenced from the swagger file.
readme: specification/voiceservices/resource-manager/readme.md
json: preview/2022-12-01-preview/examples/Operations_List.json
UNREFERENCED_JSON_FILE The example JSON file is not referenced from the swagger file.
readme: specification/voiceservices/resource-manager/readme.md
json: preview/2022-12-01-preview/examples/TestLines_CreateOrUpdate.json
UNREFERENCED_JSON_FILE The example JSON file is not referenced from the swagger file.
readme: specification/voiceservices/resource-manager/readme.md
json: preview/2022-12-01-preview/examples/TestLines_Delete.json
UNREFERENCED_JSON_FILE The example JSON file is not referenced from the swagger file.
readme: specification/voiceservices/resource-manager/readme.md
json: preview/2022-12-01-preview/examples/TestLines_Get.json
UNREFERENCED_JSON_FILE The example JSON file is not referenced from the swagger file.
readme: specification/voiceservices/resource-manager/readme.md
json: preview/2022-12-01-preview/examples/TestLines_ListByCommunicationsGateway.json
UNREFERENCED_JSON_FILE The example JSON file is not referenced from the swagger file.
readme: specification/voiceservices/resource-manager/readme.md
json: preview/2022-12-01-preview/examples/TestLines_Update.json
UNREFERENCED_JSON_FILE The swagger JSON file is not referenced from the readme file.
readme: specification/voiceservices/resource-manager/readme.md
json: Microsoft.VoiceServices/preview/2022-12-01-preview/openapi.json
️️✔️ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️~[NotRequired_Staging] SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️PR Summary succeeded [Detail] [Expand]
️️✔️Automated merging requirements met succeeded [Detail] [Expand]
Posted by Swagger Pipeline | How to fix these errors?

Copy link

Please address or respond to feedback from the ARM API reviewer.
When you are ready to continue the ARM API review, please remove the ARMChangesRequested label.
This will notify the reviewer to have another look.
If the feedback provided needs further discussion, please use this Teams channel to post your questions - aka.ms/azsdk/support/specreview-channel.
Please include [ARM Query] in the title of your question to indicate that it is ARM-related.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants