You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the automation determines you have breaking changes, i.e. Step 1 from the diagram applies to you,
you must follow the breaking changes process. IMPORTANT This applies even if:
The tool fails while it shouldn't, e.g. due to runtime exception, or incorrect detection of breaking changes.
You believe there is no need for you to request breaking change approval, for any reason.
Such claims must be reviewed, and the process is the same.
ARM API changes review (Step 2)
If this PR is in purview of ARM review then automation will add the ARMReview label.
If you want to force ARM review, add the label yourself.
Proceed according to the diagram at the top of this comment.
Viewing API changes
For convenient view of the API changes made by this PR, refer to the URLs provided in the table
in the Generated ApiView comment added to this PR. You can use ApiView to show API versions diff.
Suppressing failures
If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the Swagger-Suppression-Process
to get approval.
Getting help
For general PR approval workflow, see the diagram at the top of this comment.
For guidance on fixing this PR CI check failures, see the hyperlinks provided in given failure
and https://aka.ms/ci-fix.
❌ Your PR is in purview of ARM review (label: ARMReview). Please ensure your PR is on the ARM PR review queue - see instructions in steps 1 and 2 in the PR description diagram.
❌ The required check named Automated merging requirements met has failed. This is the final check that must pass. Refer to the check in the PR's 'Checks' tab for details on how to fix it. In addition, refer to step 4 in the PR workflow diagram (even if your PR is for data plane, not ARM).
⚠️Warning [Logs] Generate from a9d6a54ec293188df637caf6e7b0dadbadf90dfd. SDK Automation 14.0.0
command sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
cmderr [automation_init.sh] WARNING: azure-devtools 1.2.1 does not provide the extra 'ci-tools'
cmderr [automation_init.sh] WARNING: azure-devtools 1.2.1 does not provide the extra 'ci-tools'
cmderr [automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
command sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
cmderr [automation_generate.sh]
cmderr [automation_generate.sh] npm notice New major version of npm available! 9.8.1 -> 10.2.4
cmderr [automation_generate.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v10.2.4>
cmderr [automation_generate.sh] npm notice Run `npm install -g [email protected]` to update!
cmderr [automation_generate.sh] npm notice
info [Changelog] ### Features Added
info [Changelog]
info [Changelog] - Model CommunicationsGateway has a new parameter allocated_media_address_prefixes
info [Changelog] - Model CommunicationsGateway has a new parameter allocated_signaling_address_prefixes
info [Changelog] - Model CommunicationsGateway has a new parameter custom_sip_headers
info [Changelog] - Model CommunicationsGateway has a new parameter dns_delegations
info [Changelog] - Model CommunicationsGateway has a new parameter identity
info [Changelog] - Model CommunicationsGateway has a new parameter integrated_mcp_enabled
info [Changelog] - Model CommunicationsGateway has a new parameter sku
info [Changelog] - Model CommunicationsGatewayUpdate has a new parameter identity
info [Changelog] - Model CommunicationsGatewayUpdate has a new parameter sku
info [Changelog] ### Breaking Changes
info [Changelog]
info [Changelog] - Type of `CommunicationsGatewayProperties.APIBridge` has been changed from `any` to `*APIBridgeProperties`
info [Changelog]
info [Changelog] ### Features Added
info [Changelog]
info [Changelog] - New value `CommunicationsPlatformTeamsDirectRouting` added to enum type `CommunicationsPlatform`
info [Changelog] - New enum type `APIBridgeActivationState` with values `APIBridgeActivationStateDisabled`, `APIBridgeActivationStateEnabled`
info [Changelog] - New enum type `ManagedServiceIdentityType` with values `ManagedServiceIdentityTypeNone`, `ManagedServiceIdentityTypeSystemAssigned`, `ManagedServiceIdentityTypeSystemAssignedUserAssigned`, `ManagedServiceIdentityTypeUserAssigned`
info [Changelog] - New enum type `SKUTier` with values `SKUTierBasic`, `SKUTierFree`, `SKUTierPremium`, `SKUTierStandard`
info [Changelog] - New struct `APIBridgeProperties`
info [Changelog] - New struct `CustomSipHeader`
info [Changelog] - New struct `CustomSipHeadersProperties`
info [Changelog] - New struct `DNSDelegationProperties`
info [Changelog] - New struct `DNSDelegationsProperties`
info [Changelog] - New struct `ManagedServiceIdentity`
info [Changelog] - New struct `SKU`
info [Changelog] - New struct `UserAssignedIdentity`
info [Changelog] - New field `Identity`, `SKU` in struct `CommunicationsGateway`
info [Changelog] - New field `AllocatedMediaAddressPrefixes`, `AllocatedSignalingAddressPrefixes`, `CustomSipHeaders`, `DNSDelegations`, `IntegratedMcpEnabled` in struct `CommunicationsGatewayProperties`
info [Changelog] - New field `Identity`, `SKU` in struct `CommunicationsGatewayUpdate`
info [Changelog]
info [Changelog] Total 1 breaking change(s), 33 additive change(s).
️✔️Succeeded [Logs] Generate from a9d6a54ec293188df637caf6e7b0dadbadf90dfd. SDK Automation 14.0.0
command sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json
warn File azure-sdk-for-js_tmp/initOutput.json not found to read
command sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json
info [Changelog] **Features**
info [Changelog]
info [Changelog] - Added Interface ApiBridgeProperties
info [Changelog] - Added Interface CustomSipHeader
info [Changelog] - Added Interface CustomSipHeadersProperties
info [Changelog] - Added Interface DnsDelegationProperties
info [Changelog] - Added Interface DnsDelegationsProperties
info [Changelog] - Added Interface ManagedServiceIdentity
info [Changelog] - Added Interface Sku
info [Changelog] - Added Interface UserAssignedIdentity
info [Changelog] - Added Type Alias ApiBridgeActivationState
info [Changelog] - Added Type Alias ManagedServiceIdentityType
info [Changelog] - Added Type Alias SkuTier
info [Changelog] - Interface CommunicationsGateway has a new optional parameter allocatedMediaAddressPrefixes
info [Changelog] - Interface CommunicationsGateway has a new optional parameter allocatedSignalingAddressPrefixes
info [Changelog] - Interface CommunicationsGateway has a new optional parameter customSipHeaders
info [Changelog] - Interface CommunicationsGateway has a new optional parameter dnsDelegations
info [Changelog] - Interface CommunicationsGateway has a new optional parameter identity
info [Changelog] - Interface CommunicationsGateway has a new optional parameter integratedMcpEnabled
info [Changelog] - Interface CommunicationsGateway has a new optional parameter sku
info [Changelog] - Interface CommunicationsGatewaysDeleteHeaders has a new optional parameter location
info [Changelog] - Interface CommunicationsGatewayUpdate has a new optional parameter identity
info [Changelog] - Interface CommunicationsGatewayUpdate has a new optional parameter sku
info [Changelog] - Interface TestLinesDeleteHeaders has a new optional parameter location
info [Changelog] - Added Enum KnownApiBridgeActivationState
info [Changelog] - Added Enum KnownManagedServiceIdentityType
info [Changelog] - Enum KnownCommunicationsPlatform has a new value TeamsDirectRouting
info [Changelog]
info [Changelog] **Breaking Changes**
info [Changelog]
info [Changelog] - Type of parameter apiBridge of interface CommunicationsGateway is changed from Record<string, unknown> to ApiBridgeProperties
info [Changelog] Breaking Changes: /home/cloudtest/.nuget/packages/microsoft.dotnet.apicompat/5.0.0-beta.20467.1/build/Microsoft.DotNet.ApiCompat.targets(82,5): error : TypesMustExist : Type 'Azure.ResourceManager.VoiceServices.VoiceServicesCommunicationsGatewayResource' does not exist in the implementation but it does exist in the contract. [/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/voiceservices/Azure.ResourceManager.VoiceServices/src/Azure.ResourceManager.VoiceServices.csproj::TargetFramework=netstandard2.0],
info [Changelog] /home/cloudtest/.nuget/packages/microsoft.dotnet.apicompat/5.0.0-beta.20467.1/build/Microsoft.DotNet.ApiCompat.targets(82,5): error : TypesMustExist : Type 'Azure.ResourceManager.VoiceServices.VoiceServicesExtensions' does not exist in the implementation but it does exist in the contract. [/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/voiceservices/Azure.ResourceManager.VoiceServices/src/Azure.ResourceManager.VoiceServices.csproj::TargetFramework=netstandard2.0],
info [Changelog] /home/cloudtest/.nuget/packages/microsoft.dotnet.apicompat/5.0.0-beta.20467.1/build/Microsoft.DotNet.ApiCompat.targets(82,5): error : TypesMustExist : Type 'Azure.ResourceManager.VoiceServices.VoiceServicesTestLineCollection' does not exist in the implementation but it does exist in the contract. [/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/voiceservices/Azure.ResourceManager.VoiceServices/src/Azure.ResourceManager.VoiceServices.csproj::TargetFramework=netstandard2.0],
info [Changelog] /home/cloudtest/.nuget/packages/microsoft.dotnet.apicompat/5.0.0-beta.20467.1/build/Microsoft.DotNet.ApiCompat.targets(82,5): error : TypesMustExist : Type 'Azure.ResourceManager.VoiceServices.VoiceServicesTestLineData' does not exist in the implementation but it does exist in the contract. [/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/voiceservices/Azure.ResourceManager.VoiceServices/src/Azure.ResourceManager.VoiceServices.csproj::TargetFramework=netstandard2.0],
info [Changelog] /home/cloudtest/.nuget/packages/microsoft.dotnet.apicompat/5.0.0-beta.20467.1/build/Microsoft.DotNet.ApiCompat.targets(82,5): error : TypesMustExist : Type 'Azure.ResourceManager.VoiceServices.VoiceServicesTestLineResource' does not exist in the implementation but it does exist in the contract. [/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/voiceservices/Azure.ResourceManager.VoiceServices/src/Azure.ResourceManager.VoiceServices.csproj::TargetFramework=netstandard2.0],
info [Changelog] /home/cloudtest/.nuget/packages/microsoft.dotnet.apicompat/5.0.0-beta.20467.1/build/Microsoft.DotNet.ApiCompat.targets(82,5): error : TypesMustExist : Type 'Azure.ResourceManager.VoiceServices.Models.ArmVoiceServicesModelFactory' does not exist in the implementation but it does exist in the contract. [/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/voiceservices/Azure.ResourceManager.VoiceServices/src/Azure.ResourceManager.VoiceServices.csproj::TargetFramework=netstandard2.0],
info [Changelog] /home/cloudtest/.nuget/packages/microsoft.dotnet.apicompat/5.0.0-beta.20467.1/build/Microsoft.DotNet.ApiCompat.targets(82,5): error : TypesMustExist : Type 'Azure.ResourceManager.VoiceServices.Models.VoiceServicesAutoGeneratedDomainNameLabelScope' does not exist in the implementation but it does exist in the contract. [/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/voiceservices/Azure.ResourceManager.VoiceServices/src/Azure.ResourceManager.VoiceServices.csproj::TargetFramework=netstandard2.0],
info [Changelog] /home/cloudtest/.nuget/packages/microsoft.dotnet.apicompat/5.0.0-beta.20467.1/build/Microsoft.DotNet.ApiCompat.targets(82,5): error : TypesMustExist : Type 'Azure.ResourceManager.VoiceServices.Models.VoiceServicesCheckNameAvailabilityContent' does not exist in the implementation but it does exist in the contract. [/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/voiceservices/Azure.ResourceManager.VoiceServices/src/Azure.ResourceManager.VoiceServices.csproj::TargetFramework=netstandard2.0],
info [Changelog] /home/cloudtest/.nuget/packages/microsoft.dotnet.apicompat/5.0.0-beta.20467.1/build/Microsoft.DotNet.ApiCompat.targets(82,5): error : TypesMustExist : Type 'Azure.ResourceManager.VoiceServices.Models.VoiceServicesCheckNameAvailabilityResult' does not exist in the implementation but it does exist in the contract. [/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/voiceservices/Azure.ResourceManager.VoiceServices/src/Azure.ResourceManager.VoiceServices.csproj::TargetFramework=netstandard2.0],
info [Changelog] /home/cloudtest/.nuget/packages/microsoft.dotnet.apicompat/5.0.0-beta.20467.1/build/Microsoft.DotNet.ApiCompat.targets(82,5): error : TypesMustExist : Type 'Azure.ResourceManager.VoiceServices.Models.VoiceServicesCommunicationsGatewayConnectivity' does not exist in the implementation but it does exist in the contract. [/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/voiceservices/Azure.ResourceManager.VoiceServices/src/Azure.ResourceManager.VoiceServices.csproj::TargetFramework=netstandard2.0],
info [Changelog] /home/cloudtest/.nuget/packages/microsoft.dotnet.apicompat/5.0.0-beta.20467.1/build/Microsoft.DotNet.ApiCompat.targets(82,5): error : TypesMustExist : Type 'Azure.ResourceManager.VoiceServices.Models.VoiceServicesCommunicationsGatewayPatch' does not exist in the implementation but it does exist in the contract. [/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/voiceservices/Azure.ResourceManager.VoiceServices/src/Azure.ResourceManager.VoiceServices.csproj::TargetFramework=netstandard2.0],
info [Changelog] /home/cloudtest/.nuget/packages/microsoft.dotnet.apicompat/5.0.0-beta.20467.1/build/Microsoft.DotNet.ApiCompat.targets(82,5): error : TypesMustExist : Type 'Azure.ResourceManager.VoiceServices.Models.VoiceServicesCommunicationsGatewayStatus' does not exist in the implementation but it does exist in the contract. [/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/voiceservices/Azure.ResourceManager.VoiceServices/src/Azure.ResourceManager.VoiceServices.csproj::TargetFramework=netstandard2.0],
info [Changelog] /home/cloudtest/.nuget/packages/microsoft.dotnet.apicompat/5.0.0-beta.20467.1/build/Microsoft.DotNet.ApiCompat.targets(82,5): error : TypesMustExist : Type 'Azure.ResourceManager.VoiceServices.Models.VoiceServicesCommunicationsPlatform' does not exist in the implementation but it does exist in the contract. [/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/voiceservices/Azure.ResourceManager.VoiceServices/src/Azure.ResourceManager.VoiceServices.csproj::TargetFramework=netstandard2.0],
info [Changelog] /home/cloudtest/.nuget/packages/microsoft.dotnet.apicompat/5.0.0-beta.20467.1/build/Microsoft.DotNet.ApiCompat.targets(82,5): error : TypesMustExist : Type 'Azure.ResourceManager.VoiceServices.Models.VoiceServicesEmergencyCallType' does not exist in the implementation but it does exist in the contract. [/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/voiceservices/Azure.ResourceManager.VoiceServices/src/Azure.ResourceManager.VoiceServices.csproj::TargetFramework=netstandard2.0],
info [Changelog] /home/cloudtest/.nuget/packages/microsoft.dotnet.apicompat/5.0.0-beta.20467.1/build/Microsoft.DotNet.ApiCompat.targets(82,5): error : TypesMustExist : Type 'Azure.ResourceManager.VoiceServices.Models.VoiceServicesNameUnavailableReason' does not exist in the implementation but it does exist in the contract. [/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/voiceservices/Azure.ResourceManager.VoiceServices/src/Azure.ResourceManager.VoiceServices.csproj::TargetFramework=netstandard2.0],
info [Changelog] /home/cloudtest/.nuget/packages/microsoft.dotnet.apicompat/5.0.0-beta.20467.1/build/Microsoft.DotNet.ApiCompat.targets(82,5): error : TypesMustExist : Type 'Azure.ResourceManager.VoiceServices.Models.VoiceServicesPrimaryRegionProperties' does not exist in the implementation but it does exist in the contract. [/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/voiceservices/Azure.ResourceManager.VoiceServices/src/Azure.ResourceManager.VoiceServices.csproj::TargetFramework=netstandard2.0],
info [Changelog] /home/cloudtest/.nuget/packages/microsoft.dotnet.apicompat/5.0.0-beta.20467.1/build/Microsoft.DotNet.ApiCompat.targets(82,5): error : TypesMustExist : Type 'Azure.ResourceManager.VoiceServices.Models.VoiceServicesProvisioningState' does not exist in the implementation but it does exist in the contract. [/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/voiceservices/Azure.ResourceManager.VoiceServices/src/Azure.ResourceManager.VoiceServices.csproj::TargetFramework=netstandard2.0],
info [Changelog] /home/cloudtest/.nuget/packages/microsoft.dotnet.apicompat/5.0.0-beta.20467.1/build/Microsoft.DotNet.ApiCompat.targets(82,5): error : TypesMustExist : Type 'Azure.ResourceManager.VoiceServices.Models.VoiceServicesServiceRegionProperties' does not exist in the implementation but it does exist in the contract. [/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/voiceservices/Azure.ResourceManager.VoiceServices/src/Azure.ResourceManager.VoiceServices.csproj::TargetFramework=netstandard2.0],
info [Changelog] /home/cloudtest/.nuget/packages/microsoft.dotnet.apicompat/5.0.0-beta.20467.1/build/Microsoft.DotNet.ApiCompat.targets(82,5): error : TypesMustExist : Type 'Azure.ResourceManager.VoiceServices.Models.VoiceServicesTeamsCodec' does not exist in the implementation but it does exist in the contract. [/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/voiceservices/Azure.ResourceManager.VoiceServices/src/Azure.ResourceManager.VoiceServices.csproj::TargetFramework=netstandard2.0],
info [Changelog] /home/cloudtest/.nuget/packages/microsoft.dotnet.apicompat/5.0.0-beta.20467.1/build/Microsoft.DotNet.ApiCompat.targets(82,5): error : TypesMustExist : Type 'Azure.ResourceManager.VoiceServices.Models.VoiceServicesTestLinePatch' does not exist in the implementation but it does exist in the contract. [/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/voiceservices/Azure.ResourceManager.VoiceServices/src/Azure.ResourceManager.VoiceServices.csproj::TargetFramework=netstandard2.0],
info [Changelog] /home/cloudtest/.nuget/packages/microsoft.dotnet.apicompat/5.0.0-beta.20467.1/build/Microsoft.DotNet.ApiCompat.targets(82,5): error : TypesMustExist : Type 'Azure.ResourceManager.VoiceServices.Models.VoiceServicesTestLinePurpose' does not exist in the implementation but it does exist in the contract. [/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/voiceservices/Azure.ResourceManager.VoiceServices/src/Azure.ResourceManager.VoiceServices.csproj::TargetFramework=netstandard2.0],
info [Changelog] /home/cloudtest/.nuget/packages/microsoft.dotnet.apicompat/5.0.0-beta.20467.1/build/Microsoft.DotNet.ApiCompat.targets(96,5): error : ApiCompat failed for '/mnt/vss/_work/1/s/azure-sdk-for-net/artifacts/bin/Azure.ResourceManager.VoiceServices/Debug/netstandard2.0/Azure.ResourceManager.VoiceServices.dll' [/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/voiceservices/Azure.ResourceManager.VoiceServices/src/Azure.ResourceManager.VoiceServices.csproj::TargetFramework=netstandard2.0]
error Fatal error: SSL error: syscall failure: Broken pipe
error The following packages are still pending:
error Az.voiceservices.DefaultTag
error Az.VoiceServices.Autorest
️️✔️PR Summary succeeded [Detail] [Expand]
️️✔️Automated merging requirements met succeeded [Detail] [Expand]
Posted by Swagger Pipeline | How to fix these errors?
Please address or respond to feedback from the ARM API reviewer. When you are ready to continue the ARM API review, please remove the ARMChangesRequested label. This will notify the reviewer to have another look. If the feedback provided needs further discussion, please use this Teams channel to post your questions - aka.ms/azsdk/support/specreview-channel. Please include [ARM Query] in the title of your question to indicate that it is ARM-related.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ARM (Control Plane) API Specification Update Pull Request
PR review workflow diagram
Please understand this diagram before proceeding. It explains how to get your PR approved & merged.
[1] ARM review queue (for merge queues, see [4])
The PRs are processed by time opened, ascending. Your PR may show up on 2nd or later page.
If you addressed Step 1 from the diagram and your PR is not showing up in the queue, ensure the label
ARMChangesRequested
is removed from your PR. This should cause the label
WaitForARMFeedback
to be added.[2] https://aka.ms/azsdk/support/specreview-channel
[3] List of SDK breaking changes approvers in pinned Teams announcement
[4] public repo merge queue, private repo merge queue (for ARM review queue, [1])
If you need further help with anything, see
Getting help
section below.Purpose of this PR
What's the purpose of this PR? Check all that apply. This is mandatory!
Due diligence checklist
To merge this PR, you must go through the following checklist and confirm you understood
and followed the instructions by checking all the boxes:
ARM resource provider contract and
REST guidelines (estimated time: 4 hours).
I understand this is required before I can proceed to Step 2, "ARM Review", for this PR.
Breaking changes review (Step 1)
you must follow the breaking changes process.
IMPORTANT This applies even if:
Such claims must be reviewed, and the process is the same.
ARM API changes review (Step 2)
ARMReview
label.Viewing API changes
For convenient view of the API changes made by this PR, refer to the URLs provided in the table
in the
Generated ApiView
comment added to this PR. You can use ApiView to show API versions diff.Suppressing failures
If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the
Swagger-Suppression-Process
to get approval.
Getting help
and https://aka.ms/ci-fix.