[Test] Add a path #3102
Open
[Test] Add a path #3102
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update widgets.json
Update widgets.json
…sting Update widgets.json
…st-1 Update widgets.json
Testing assistant
…sistant Testing with spec change
* Rename bug.md to bug_report.md * Create config.yml
[Internal testing] testing openapi-alps PR 510778 - Test 11/14/2023 / 1
[Internal testing] testing openapi-alps PR 510778 - Test 11/14/2023 / 2
[Internal testing] testing openapi-alps PR 510778 - Test 11/15/2023 / 1
[Internal testing] testing openapi-alps PR 511346 - Test 1
Next Steps to mergeNext steps that must be taken to merge this PR:
|
Swagger Generation Artifacts
|
Generated ApiView
|
Swagger Validation Report
|
| compared swaggers (via Oad v0.10.4)] | new version | base version |
|---|---|---|
| servicelinker.json | 2022-05-01(f755ce1) | 2022-05-01(main) |
| Rule | Message |
|---|---|
|
The new version is missing a path that was found in the old version. Was path '/{resourceUri}/providers/Microsoft.ServiceLinker/linkers/{linkerName}/validateLinker' removed or restructured? Old: Microsoft.ServiceLinker/stable/2022-05-01/servicelinker.json#L269:5 |
|
The new version is missing a path that was found in the old version. Was path '/{resourceUri}/providers/Microsoft.ServiceLinker/linkers/{linkerName}/listConfigurations' removed or restructured? Old: Microsoft.ServiceLinker/stable/2022-05-01/servicelinker.json#L315:5 |
|
The new version is adding a path that was not found in the old version. New: Microsoft.ServiceLinker/stable/2022-05-01/servicelinker.json#L269:5 |
️️✔️Breaking Change(Cross-Version) succeeded [Detail] [Expand]
There are no breaking changes.
️❌LintDiff: 2 Errors, 3 Warnings failed [Detail]
| compared tags (via openapi-validator v2.1.6) | new version | base version |
|---|---|---|
| package-2022-05-01 | package-2022-05-01(f755ce1) | package-2022-05-01(main) |
[must fix]The following errors/warnings are introduced by current PR:
| Rule | Message | Related RPC [For API reviewers] |
|---|---|---|
|
The resource name parameter 'linkerName' should be defined with a 'pattern' restriction. Location: Microsoft.ServiceLinker/stable/2022-05-01/servicelinker.json#L269 |
RPC-Uri-V1-05 |
|
A 202 response should include an Location response header. Location: Microsoft.ServiceLinker/stable/2022-05-01/servicelinker.json#L303 |
RPC-Async-V1-07 |
| OperationId should contain the verb: 'revalidatelinkers' in:'Linker_ReValidate'. Consider updating the operationId Location: Microsoft.ServiceLinker/stable/2022-05-01/servicelinker.json#L274 |
||
| Use the latest version v5 of types.json. Location: Microsoft.ServiceLinker/stable/2022-05-01/servicelinker.json#L290 |
||
| Use the latest version v5 of types.json. Location: Microsoft.ServiceLinker/stable/2022-05-01/servicelinker.json#L309 |
The following errors/warnings exist before current PR submission:
️️✔️~[NotRequired_Staging] Lint(RPaaS) succeeded [Detail] [Expand]
Validation passes for Lint(RPaaS).
️️✔️SwaggerAPIView succeeded [Detail] [Expand]
️️✔️TypeSpecAPIView succeeded [Detail] [Expand]
️️✔️CredScan succeeded [Detail] [Expand]
There is no credential detected.
️️✔️PoliCheck succeeded [Detail] [Expand]
Validation passed for PoliCheck.
️❌Avocado: 2 Errors, 0 Warnings failed [Detail]
| Rule | Message |
|---|---|
|
The example JSON file is not referenced from the swagger file. readme: specification/servicelinker/resource-manager/readme.md json: stable/2022-05-01/examples/GetConfigurations.json |
|
The example JSON file is not referenced from the swagger file. readme: specification/servicelinker/resource-manager/readme.md json: stable/2022-05-01/examples/ValidateLinkSuccess.json |
️❌ModelValidation: 8 Errors, 0 Warnings failed [Detail]
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️~[NotRequired_Staging] SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️PR Summary succeeded [Detail] [Expand]
️️✔️Automated merging requirements met succeeded [Detail] [Expand]
|
Please address or respond to feedback from the ARM API reviewer. |
This was referenced Nov 30, 2023
Closed
This was referenced Nov 30, 2023
Closed
konrad-jamrozik
force-pushed
the
main
branch
from
6f9f31c to
d8e7a99
Compare
ankhyk
requested review from
weshaggard,
mikeharder and
konrad-jamrozik
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ARM (Control Plane) API Specification Update Pull Request
PR review workflow diagram
Please understand this diagram before proceeding. It explains how to get your PR approved & merged.
[1] ARM review queue (for merge queues, see [4])
The PRs are processed by time opened, ascending. Your PR may show up on 2nd or later page.
If you addressed Step 1 from the diagram and your PR is not showing up in the queue, ensure the label
ARMChangesRequestedis removed from your PR. This should cause the label
WaitForARMFeedbackto be added.[2] https://aka.ms/azsdk/support/specreview-channel
[3] List of SDK breaking changes approvers in pinned Teams announcement
[4] public repo merge queue, private repo merge queue (for ARM review queue, [1])
If you need further help with anything, see
Getting helpsection below.Purpose of this PR
What's the purpose of this PR? Check all that apply. This is mandatory!
Due diligence checklist
To merge this PR, you must go through the following checklist and confirm you understood
and followed the instructions by checking all the boxes:
ARM resource provider contract and
REST guidelines (estimated time: 4 hours).
I understand this is required before I can proceed to Step 2, "ARM Review", for this PR.
Breaking changes review (Step 1)
you must follow the breaking changes process.
IMPORTANT This applies even if:
Such claims must be reviewed, and the process is the same.
ARM API changes review (Step 2)
ARMReviewlabel.Viewing API changes
For convenient view of the API changes made by this PR, refer to the URLs provided in the table
in the
Generated ApiViewcomment added to this PR. You can use ApiView to show API versions diff.Suppressing failures
If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the
Swagger-Suppression-Process
to get approval.
Getting help
and https://aka.ms/ci-fix.