Always set the ORACLE_DATABASE environment variable

Older images that don't support a custom database will simply ignore it.
testcontainers · Feb 16, 2025 · e17bd73 · e17bd73
1 parent a311829
commit e17bd73
Showing 1 changed file with 2 additions and 6 deletions.
diff --git a/src/Testcontainers.Oracle/OracleBuilder.cs b/src/Testcontainers.Oracle/OracleBuilder.cs
@@ -47,7 +47,8 @@ private OracleBuilder(OracleConfiguration resourceConfiguration)
     /// <returns>A configured instance of <see cref="OracleBuilder" />.</returns>
     public OracleBuilder WithDatabase(string database)
     {
-        return Merge(DockerResourceConfiguration, new OracleConfiguration(database: database));
+        return Merge(DockerResourceConfiguration, new OracleConfiguration(database: database))
+            .WithEnvironment("ORACLE_DATABASE", database);
     }
 
     /// <summary>
@@ -84,11 +85,6 @@ public override OracleContainer Build()
             return new OracleContainer(WithDatabase(defaultServiceName).DockerResourceConfiguration);
         }
 
-        if (DockerResourceConfiguration.Database != defaultServiceName)
-        {
-            return new OracleContainer(WithEnvironment("ORACLE_DATABASE", DockerResourceConfiguration.Database).DockerResourceConfiguration);
-        }
-
         return new OracleContainer(DockerResourceConfiguration);
     }