Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add Db2 module #1237

Merged
merged 57 commits into from
Feb 14, 2025
Merged

Conversation

kevin0x90
Copy link
Contributor

What does this PR do?

Adds a module to use Db2 with testcontainers.

How to test this PR

Automated tests have been added to the project that verify startup and database connectivity.

Copy link

netlify bot commented Aug 20, 2024

Deploy Preview for testcontainers-dotnet ready!

Name Link
🔨 Latest commit 61bfd3d
🔍 Latest deploy log https://app.netlify.com/sites/testcontainers-dotnet/deploys/66c45ad21aeb910008c69a02
😎 Deploy Preview https://deploy-preview-1237--testcontainers-dotnet.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Aug 20, 2024

Deploy Preview for testcontainers-dotnet ready!

Name Link
🔨 Latest commit 7fc391b
🔍 Latest deploy log https://app.netlify.com/sites/testcontainers-dotnet/deploys/67ae0b8b9263f000080ebcee
😎 Deploy Preview https://deploy-preview-1237--testcontainers-dotnet.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@HofmeisterAn HofmeisterAn added enhancement New feature or request module An official Testcontainers module labels Aug 29, 2024
@HofmeisterAn HofmeisterAn changed the base branch from develop to main January 27, 2025 19:31
@HofmeisterAn HofmeisterAn changed the base branch from main to develop January 27, 2025 19:31
Copy link
Collaborator

@HofmeisterAn HofmeisterAn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR and your contribution! I apologize for the delayed review and feedback. I just hadn't found the time earlier. I have a few minor change requests (or questions), but nothing major. I'm happy to merge the PR once those are addressed 🙏.

Copy link
Collaborator

@HofmeisterAn HofmeisterAn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating the PR. I've updated the remaining parts. The PR looks good! If you're okay with it, I'm happy to merge it.

I just have one final question: Does it make sense to set any of these configurations as defaults (in Init()) to improve startup performance (or improves development experience)?

.WithEnvironment("TO_CREATE_SAMPLEDB", "false")
.WithEnvironment("PERSISTENT_HOME", "true")
.WithEnvironment("REPODB", "false")
.WithEnvironment("BLU", "false")
.WithEnvironment("HADR_ENABLED", "false")
.WithEnvironment("ARCHIVE_LOGS", "false")
.WithEnvironment("AUTOCONFIG", "false")

@HofmeisterAn HofmeisterAn changed the title Add Db2 module feat: Add DB2 module Feb 13, 2025
@HofmeisterAn HofmeisterAn changed the title feat: Add DB2 module feat: Add Db2 module Feb 14, 2025
@HofmeisterAn HofmeisterAn merged commit 7715969 into testcontainers:develop Feb 14, 2025
60 checks passed
@kevin0x90 kevin0x90 deleted the Db2Support branch February 15, 2025 21:06
@kevin0x90
Copy link
Contributor Author

kevin0x90 commented Feb 15, 2025

Thanks for updating the PR. I've updated the remaining parts. The PR looks good! If you're okay with it, I'm happy to merge it.

I just have one final question: Does it make sense to set any of these configurations as defaults (in Init()) to improve startup performance (or improves development experience)?

.WithEnvironment("TO_CREATE_SAMPLEDB", "false")
.WithEnvironment("PERSISTENT_HOME", "true")
.WithEnvironment("REPODB", "false")
.WithEnvironment("BLU", "false")
.WithEnvironment("HADR_ENABLED", "false")
.WithEnvironment("ARCHIVE_LOGS", "false")
.WithEnvironment("AUTOCONFIG", "false")

Thank you very much for finishing up the PR for the parts I had not addressed yet. Yes it would have some positive effect regarding startup performance but in general the official image takes quite some time to startup even with the optimizations so I’m not sure if it makes a big difference.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request module An official Testcontainers module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants