Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add Weaviate module #1356

Merged
merged 6 commits into from
Feb 2, 2025
Merged

Conversation

roji
Copy link
Contributor

@roji roji commented Jan 31, 2025

This adds a minimal .NET Testcontainer for Weaviate, the vector database, following the Go and Java testcontainers.

Copy link

netlify bot commented Jan 31, 2025

Deploy Preview for testcontainers-dotnet ready!

Name Link
🔨 Latest commit eabc1fd
🔍 Latest deploy log https://app.netlify.com/sites/testcontainers-dotnet/deploys/679f3f586363b2000876bc14
😎 Deploy Preview https://deploy-preview-1356--testcontainers-dotnet.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Xor-el
Copy link

Xor-el commented Jan 31, 2025

Hi @roji, you need to add your Weaviate module to this cicd file to fix your pipeline build error.

@roji
Copy link
Contributor Author

roji commented Feb 1, 2025

Hi @roji, you need to add your Weaviate module to this cicd file to fix your pipeline build error.

Thanks, done.

@roji roji requested a review from Xor-el February 1, 2025 08:31
@roji
Copy link
Contributor Author

roji commented Feb 1, 2025

Done, switched to global usings in Usings files for both the implementation and the tests. Interesting, I use global usings, but via the csproj, not via a separate file typically.

@roji roji requested a review from Xor-el February 1, 2025 14:22
Copy link

@Xor-el Xor-el left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 🚀
now we wait for @HofmeisterAn review and approval.

@roji
Copy link
Contributor Author

roji commented Feb 2, 2025

Thanks @Xor-el!

Copy link
Collaborator

@HofmeisterAn HofmeisterAn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. I made a few minor changes to align with the repository standard and removed the MSFT copyright header, as I assume that was not intentional.

In addition, I added a GetBaseAddress() method to the container type, allowing us to set the base address for the HTTP client without recreating it repeatedly.

If you're okay with these changes, I'm happy to merge the PR, everything looks good. Thanks again 🙏.

@roji
Copy link
Contributor Author

roji commented Feb 2, 2025

Of course! More than fine with the changes, thanks. Feel free to merge.

@roji
Copy link
Contributor Author

roji commented Feb 2, 2025

(I'm assuming the docs here will get updated with it - if you need help with that let me know)

@HofmeisterAn
Copy link
Collaborator

(I'm assuming the docs here will get updated with it - if you need help with that let me know)

Thanks for the heads-up. I usually don't check the module catalog, but I will create a PR there. Thanks.

@HofmeisterAn HofmeisterAn added enhancement New feature or request module An official Testcontainers module labels Feb 2, 2025
@HofmeisterAn HofmeisterAn changed the title Add Testcontainers.Weaviate feat: Add Weaviate module Feb 2, 2025
@HofmeisterAn HofmeisterAn merged commit 40227bf into testcontainers:develop Feb 2, 2025
58 checks passed
@HofmeisterAn
Copy link
Collaborator

I created a draft PR for the module catalog. I will merge it as soon as we publish the new TC for the .NET version: testcontainers/community-module-registry#106.

@roji roji deleted the Weaviate branch February 2, 2025 14:05
@roji
Copy link
Contributor Author

roji commented Feb 2, 2025

@HofmeisterAn thank you very much! I may do a similar PR for Qdrant soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request module An official Testcontainers module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants