Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Set PackageLicenseExpression property to MIT #1368

Conversation

ax-meyer
Copy link
Contributor

@ax-meyer ax-meyer commented Feb 11, 2025

What does this PR do?

Switches from using the license file to indicate the license in the nuget package to using PackageLicenseExpression to explicitly define the license for the nugets.

Why is it important?

This allows

Related issues

  • no releated issues

Manual test:

  • Run nuget pack for any project in the repo
  • Start manual upload process for a nuget here: https://www.nuget.org/packages/manage/upload
  • The page will show the package metadata with license information for verification before finishing the upload

Switch to using PackageLicenseExpression for nugets so the license is displayed on the nuget page and consumable for tools like nuget-license
Copy link

netlify bot commented Feb 11, 2025

Deploy Preview for testcontainers-dotnet ready!

Name Link
🔨 Latest commit f939e86
🔍 Latest deploy log https://app.netlify.com/sites/testcontainers-dotnet/deploys/67ab1c9b7bc6eb000804cb07
😎 Deploy Preview https://deploy-preview-1368--testcontainers-dotnet.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@HofmeisterAn HofmeisterAn changed the title Swith to PackageLicenseExpression to include the license in nuget packages chore: Set PackageLicenseExpression property to MIT Feb 11, 2025
@HofmeisterAn HofmeisterAn added the chore A change that doesn't impact the existing functionality, e.g. internal refactorings or cleanups label Feb 11, 2025
Copy link
Collaborator

@HofmeisterAn HofmeisterAn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 💪.

@HofmeisterAn HofmeisterAn merged commit b93162c into testcontainers:develop Feb 11, 2025
59 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore A change that doesn't impact the existing functionality, e.g. internal refactorings or cleanups
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants