Skip to content

Add UDP support for GenericContainer and DockerComposeContainer #2989

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add UDP support for GenericContainer and DockerComposeContainer #2989

wants to merge 1 commit into from

Conversation

mkrzywanski
Copy link

@mkrzywanski mkrzywanski commented Jul 11, 2020 •
edited
Loading

Added support for udp protocol for GenericContainer and DockerComposeContainer.

@kiview
Copy link
Member

kiview commented Jul 11, 2020

Would fix #554

@mkrzywanski mkrzywanski marked this pull request as ready for review July 12, 2020 09:33
@mkrzywanski mkrzywanski force-pushed the feature/issue-554-udp branch 2 times, most recently from 3766b11 to 5a2c5ed Compare July 16, 2020 14:23
@mkrzywanski mkrzywanski force-pushed the feature/issue-554-udp branch from 001866d to 49b3df1 Compare July 16, 2020 21:34
@rnorth
Copy link
Member

rnorth commented Jul 17, 2020

We will review this, however it's a fairly big PR with potentially breaking changes, so it may take time.

@mkrzywanski mkrzywanski mentioned this pull request Jul 19, 2020
Closed
@kiview kiview changed the title Issue 554 added udp support for generic container and docker compose … Add udp support for GenericContainer and DockerComposeContainer Jul 24, 2020
@kiview kiview changed the title Add udp support for GenericContainer and DockerComposeContainer Add UDP support for GenericContainer and DockerComposeContainer Jul 24, 2020
@stale
Copy link

stale bot commented Jan 24, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. If you believe this is a mistake, please reply to this comment to keep it open. If there isn't one already, a PR to fix or at least reproduce the problem in a test case will always help us get back on track to tackle this.

@stale stale bot added the stale label Jan 24, 2021
@mbesida
Copy link

mbesida commented Apr 8, 2021

so what's the status of this? Is it going to be rejected?

@stale stale bot removed the stale label Apr 8, 2021
@bsideup
Copy link
Member

bsideup commented Apr 9, 2021

@mbesida there are breaking changes that should be reverted.

Also note that even UDP if not provided as a set of convenient methods, it is possible to do it with low level API:
https://www.testcontainers.org/features/advanced_options/#customizing-the-container
and GenericContainer#getContainerInfo

@eddumelendez eddumelendez requested a review from a team as a code owner November 19, 2024 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bsideup bsideup Awaiting requested review from bsideup

@kiview kiview Awaiting requested review from kiview

@rnorth rnorth Awaiting requested review from rnorth

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
type/feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mkrzywanski @kiview @rnorth @mbesida @bsideup