Change mssql url parsing to honor passing parameters (#5728) #5736
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bsofiato
requested review from
rnorth,
bsideup,
kiview and
a team
as code owners
kiview
added
modules/jdbc
modules/mysql
modules/sql-server
type/enhancement
and removed
modules/mysql
labels
bsofiato
force-pushed
the
mssql-connection
branch
from
d682475 to
7434652
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR should deal with the issue describe on #5728
When writing this PR, I found some points for improvement. I, however, chose not to do it since it would require more profound changes that might be out of the scope of this PR.
The first point of improvement is refactoring the ConnectionUrl::parseUrl method. It has logic to parse oracle, generic, and now MSSQL-based URLs. Maybe we change it a little bit to employ a chain of responsibility that deal with each database.
Another point of improvement lies in the MSSQLServerContainer class. We could change its constructUrlForConnection method to allow different separators by turning it on a template method.
Again, I feel these changes are too profound to incorporate into this issue. Still, if you guys think it is worth it, I will do it. ;)