Add JDBC URL option TC_COPY_FILE, copying files to container #6387
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
larsmoil
commented
Jan 4, 2023
| @@ -204,13 +205,13 @@ private HikariDataSource verifyCharacterSet(String jdbcUrl) throws SQLException | |||
| private void performTestForCustomIniFile(HikariDataSource dataSource) throws SQLException { | |||
| assumeFalse(SystemUtils.IS_OS_WINDOWS); | |||
| Statement statement = dataSource.getConnection().createStatement(); | |||
| statement.execute("SELECT @@GLOBAL.innodb_file_format"); | |||
| statement.execute("SELECT @@GLOBAL.key_buffer_size"); | |||
There was a problem hiding this comment.
Barracuda was already the default value for innodb_file_format, thus not actually testing the config was applied. I doubled the value of key_buffer_size in the ini file and asserted based on that instead.
There was a problem hiding this comment.
This might be the reason why the mariadb tests fail.
|
The |
* Change the way file vs. classpath resources work * Change the way we specify multiple files
…* Change the way file vs. classpath resources work * Change the way we specify multiple files
eddumelendez
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds another option,
TC_COPY_FILE, to the JDBC URL scheme. It enables one to copy files into the container image.jdbc:tc:...?TC_COPY_FILE=relative-path/file:/container-path/the-filejdbc:tc:...?TC_COPY_FILE=relative-path/file:/container-path/the-file:755jdbc:tc:...?TC_COPY_FILE=relative-path/file:/container-path/the-file&TC_COPY_FILE=file:/absolute-path/another-file:/container-path/antoher-file:755