Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tests): Missing artifacts (include-hidden-files) #699

Merged
merged 1 commit into from
Sep 8, 2024

Conversation

Tranquility2
Copy link
Contributor

upload-artifact updated behavior: Hidden Files will be excluded by default
actions/upload-artifact#602

Need to include

include-hidden-files: true

upload-artifact updated behavior: Hidden Files will be excluded by default
actions/upload-artifact#602

Need to include

include-hidden-files: true
@Tranquility2 Tranquility2 changed the title fix: tests artifacts (include-hidden-files) fix: Missing tests artifacts (include-hidden-files) Sep 8, 2024
@Tranquility2 Tranquility2 changed the title fix: Missing tests artifacts (include-hidden-files) fix(test): Missing artifacts (include-hidden-files) Sep 8, 2024
@Tranquility2 Tranquility2 changed the title fix(test): Missing artifacts (include-hidden-files) fix(tests): Missing artifacts (include-hidden-files) Sep 8, 2024
Copy link

codecov bot commented Sep 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (main@f1665f3). Learn more about missing BASE report.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #699   +/-   ##
=======================================
  Coverage        ?   80.39%           
=======================================
  Files           ?       12           
  Lines           ?      607           
  Branches        ?       90           
=======================================
  Hits            ?      488           
  Misses          ?       92           
  Partials        ?       27           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Tranquility2
Copy link
Contributor Author

@alexanderankin this is needed to make the CI tests pass.
Sadly actions/upload-artifact#602 did a breaking change without adhering to semantic versioning..

@alexanderankin
Copy link
Collaborator

fascinating

@alexanderankin alexanderankin merged commit 8f1165d into testcontainers:main Sep 8, 2024
11 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants