Skip to content

Please add cpu and memory limits #776

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

bitemyapp
Copy link

No description provided.

@bitemyapp bitemyapp force-pushed the bitemyapp/please-add-cpu-and-memory-limits branch from 54851fd to fbe3f54 Compare March 10, 2025 17:55
Copy link

netlify bot commented Mar 10, 2025

Deploy Preview for testcontainers-rust ready!

Name Link
🔨 Latest commit 54851fd
🔍 Latest deploy log https://app.netlify.com/sites/testcontainers-rust/deploys/67cf27913413cf00096b539d
😎 Deploy Preview https://deploy-preview-776--testcontainers-rust.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Mar 10, 2025

Deploy Preview for testcontainers-rust ready!

Name Link
🔨 Latest commit fbe3f54
🔍 Latest deploy log https://app.netlify.com/sites/testcontainers-rust/deploys/67cf279d710f4b0008ed5dc3
😎 Deploy Preview https://deploy-preview-776--testcontainers-rust.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@DDtKey
Copy link
Collaborator

DDtKey commented Mar 25, 2025

Sorry, I somehow missed the PR.
Thank you for the contribution.

This change introduces quite a lot of options, I don't even think testcontainers in other languages allows to change the defaults for these options. Not that common use-case for testing I guess.

However - the docker client is usually exposed (see docker_client_instance), so it's possible to update the container's config via update_container

Do we really need to expose these configs? We can create an issue and check if it's common request and update_container isn't enough for some reason

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants