Skip to content

Remove support for Python 3.8 + deprecated methods and classes #424

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 2, 2025

Conversation

stephenfin
Copy link
Contributor

  • Drop support for Python 3.8
  • Remove remnants of setuptools
  • Remove deprecated classes, methods
  • Resolve deprecation warning

Copy link
Member

@jelmer jelmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but looks like there are some test failures.

@jelmer
Copy link
Member

jelmer commented Feb 22, 2025

@stephenfin looks like it just needs to have "ruff format" run on it

@stephenfin stephenfin force-pushed the cleanup branch 2 times, most recently from 3460916 to 55b7633 Compare February 25, 2025 18:27
Signed-off-by: Stephen Finucane <[email protected]>
@stephenfin stephenfin force-pushed the cleanup branch 2 times, most recently from 5e79be6 to 9c9a2ff Compare April 1, 2025 16:25
We also move stuff around pyproject.toml to keep related things together
and allow users to use the package without installing it or having
setuptools_scm installed..

Signed-off-by: Stephen Finucane <[email protected]>
Signed-off-by: Stephen Finucane <[email protected]>
See [1] for more info.

[1] python/cpython#79893

Signed-off-by: Stephen Finucane <[email protected]>
@jelmer jelmer merged commit 5ef6fdb into testing-cabal:master Apr 2, 2025
7 checks passed
@stephenfin stephenfin deleted the cleanup branch April 3, 2025 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants