Skip to content

chore(release): promote v5 as an main consumption release #352

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Apr 18, 2024
Merged

chore(release): promote v5 as an main consumption release #352

merged 10 commits into from
Apr 18, 2024

Conversation

yanick
Copy link
Collaborator

@yanick yanick commented Apr 18, 2024

No description provided.

mcous and others added 10 commits February 13, 2024 13:11
@mcous
feat: add Svelte v5-next support (#321)
178b2de 
* fix: remove DOM elements even if component creation fails

Fixes #190

* feat: add Svelte v5-next support
@yanick
fix: $destroy and createRoot are no more (#328)
40973c5 
* fix: make the latest Svelte 5 pass all tests

For now I've resorted to use the legacy API, as
the use of runes don't seem to work in the test
environment (which, mind you, could be a problem on this side
of the keyboard) and the important part is to have the package
work with Svelte 5.
@yanick
refactor: implement inheritance with classes (#330)
0593819
@mcous
fix!: align target and baseElement options with testing-library (#…
8d98aa5 
…325)

Fixes #312, fixes #313

BREAKING CHANGES: The `container` option has been renamed to `baseElement`,
  `result.container` is now set to `target` rather than `baseElement`,
  and `render` will now throw if you mix props with the `target` option.
@mcous
test: remove unnecessary tests and skips (#338)
16f6b40
@mcous
fix: ensure fireEvent is exported (#339)
40feeb4
@mcous
ci: run weekly check with latest svelte versions (#344)
d4e60f7
@mcous
test: remove Svelte 5 + HappyDOM skips after bugfix (#348)
e951b9a
@mcous
fix(svelte5): ensure proper act used in cleanup (#346)
3eaa04e
@mcous
chore(release): note breaking changes for v5 (#347)
496c455 
BREAKING CHANGE: `render` is now more strict about the `target`
option, and the `container` result is now the direct parent of
your component instance.
@mcous
Copy link
Collaborator

mcous commented Apr 18, 2024

Uh oh, looks like our accessors test broke in latest Svelte 5! No need to block promotion to main in my mind; we can continue to fix Svelte 5 issues as they come up

From reading the semantic-release docs, we should make sure this PR lands into main as a regular merge commit, not a squash

@yanick
Copy link
Collaborator Author

yanick commented Apr 18, 2024

Uh oh, looks like our accessors test broke in latest Svelte 5! No need to block promotion to main in my mind; we can continue to fix Svelte 5 issues as they come up

I was looking into it, but you have a good point. I'll deploy and create the issue for the follow-up.

From reading the semantic-release docs, we should make sure this PR lands into main as a regular merge commit, not a squash

Makes sense. For the "short" feature branches, you just want the "atomic" deltas (man, those quotes in this sentence are doing some heavy work...), but for the next->main you want a better history. Now, I just have to remember that for the next 10 minutes. :-)

@yanick
Copy link
Collaborator Author

yanick commented Apr 18, 2024

:take a deep breath: Here comes nothing...

@yanick yanick merged commit 42a4ce9 into main Apr 18, 2024
27 of 31 checks passed
@yanick yanick mentioned this pull request Apr 18, 2024
Closed
@github-actions GitHub Actions
Copy link

🎉 This PR is included in version 5.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions GitHub Actions
Copy link

🎉 This PR is included in version 5.0.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yanick @mcous