Add methods to navigate revisions: next, isFirstRevision, and isLastR… - #17
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds revision-navigation helpers to the Revision model and introduces a dedicated test suite to validate navigating between adjacent revisions and detecting boundary revisions.
Changes:
- Adds
next()to fetch the immediate subsequent revision for the same revisionable model. - Adds
isFirstRevision()/isLastRevision()convenience helpers onRevision. - Adds
RevisionNavigationTestcoverage forprevious(),next(), and first/last detection.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
tests/RevisionNavigationTest.php |
Adds unit tests validating previous/next navigation and first/last revision checks. |
src/Models/Revision.php |
Implements next(), isFirstRevision(), and isLastRevision() on the Revision model. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+189
to
+193
| /** | ||
| * Return the revision that directly follows this one for the same model. | ||
| */ | ||
| public function next(): ?static | ||
| { |
Comment on lines
+207
to
+210
| public function isFirstRevision(): bool | ||
| { | ||
| return $this->getKey() === $this->revisionable->revisions->min($this->getKeyName()); | ||
| } |
Comment on lines
+215
to
+218
| public function isLastRevision(): bool | ||
| { | ||
| return $this->getKey() === $this->revisionable->revisions->max($this->getKeyName()); | ||
| } |
stefanius
approved these changes
Jul 9, 2026
…or single and unsaved revisions
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
stefanius
approved these changes
Jul 9, 2026
Comment on lines
16
to
22
| public function previous(): ?static; | ||
|
|
||
| public function next(): ?static; | ||
|
|
||
| public function diff(?self $target = null): Diff; | ||
|
|
||
| public function toModel(): Model; |
Comment on lines
16
to
+19
| public function previous(): ?static; | ||
|
|
||
| public function next(): ?static; | ||
|
|
Comment on lines
+207
to
+218
| public function isFirstRevision(): bool | ||
| { | ||
| return $this->exists && $this->previous() === null; | ||
| } | ||
|
|
||
| /** | ||
| * Determine whether this is the most recent revision for its model. | ||
| */ | ||
| public function isLastRevision(): bool | ||
| { | ||
| return $this->exists && $this->next() === null; | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…evision