Refactor diff detection for direct relations - #27
Merged
Conversation
thijskok
commented
Jul 21, 2026
| */ | ||
| protected function diffPivotedRelation(array $before, array $after, string $relatedKey): array | ||
| { | ||
| $beforeIds = array_column($before['pivots']['items'] ?? [], $relatedKey); |
Contributor
Author
There was a problem hiding this comment.
Moved this code to a helper below
Contributor
There was a problem hiding this comment.
Pull request overview
Refactors relation diffing in Diff to share logic between pivoted and direct relations, and expands direct-relation diffs to report per-record field changes (not just added/removed), aligning behavior with pivoted relation diffs.
Changes:
- Extracted shared relation-item diff logic into
Diff::diffItemsByKey()and reused it for both pivoted and direct relations. - Updated direct relation diffing to populate the
changedbucket for existing related records whose fields changed. - Added a regression test ensuring direct-relation record changes are surfaced via
Diff::changes().
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| tests/RevisionDiffTest.php | Adds coverage to assert that updates to an existing direct-related record appear under changed. |
| src/Diff.php | Refactors and unifies relation diffing; enables column-level change detection for direct relations via a shared helper. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Frankisgek
approved these changes
Jul 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.