Enhance rollback event listeners to include target revision for mutat… - #28
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Enhances the rollback event system in HasRevisions so rollback listeners can receive (and optionally mutate) the specific target revision being rolled back to, with accompanying tests to validate the new behavior.
Changes:
- Adds tests to ensure
rollingBack/rolledBacklisteners receive the targetRevisionand can mutate it before restore. - Updates rollback event dispatching to pass the target revision through a new
fireRevisionEvent()helper and refreshes event docblocks.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| tests/RevisionEventsTest.php | Adds/adjusts test coverage for passing the target revision to rollback listeners and allowing mutation before restore. |
| src/Concerns/HasRevisions.php | Dispatches rollback events with both model + target revision via fireRevisionEvent() and updates event documentation. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
283
to
286
| public function rollbackToRevision(RevisionContract $revision): bool | ||
| { | ||
| if ($this->fireModelEvent('rollingBack') === false) { | ||
| if ($this->fireRevisionEvent('rollingBack', true, $revision) === false) { | ||
| return false; |
Contributor
Author
There was a problem hiding this comment.
Nopes, not relevant yet.
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
Frankisgek
approved these changes
Jul 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ion and verification