Capturing database default values on initial creation - #29
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR ensures revisions/diffs capture database-assigned default column values immediately after a model is created, while preserving any unsaved in-memory mutations made right after creation.
Changes:
- Added coverage to assert DB defaults (e.g.,
votes,views, nullablecontent) are present in the initial revision snapshot when revision-on-create is enabled. - Updated revision snapshot building to backfill missing attributes from a freshly loaded instance when
wasRecentlyCreatedis true, without overwriting in-memory changes. - Tightened/clarified several event/docblock descriptions in
HasRevisions.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| tests/RevisionDiffTest.php | Adds a regression test ensuring diffing right after create preserves unsaved mutations. |
| tests/CreatingRevisionsTest.php | Adds a test asserting initial revisions include DB default values when enabled on create. |
| src/Revisioner.php | Backfills DB-assigned defaults for recently-created models by merging in fresh() attributes. |
| src/Concerns/HasRevisions.php | Docblock clarifications for rollback-related events and diff description. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Frankisgek
approved these changes
Jul 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.