Restore Ordering for DependsOnGroups by using Priority on Configuration Methods alternative 1 #2667
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Restore Ordering for DependsOnGroups.
3 tasks
| m2.addMethodDependedUpon(MethodHelper.calculateMethodCanonicalName(m1)); | ||
| if (m1.getPriority() == 0 | ||
| && m2.getPriority() == 0 | ||
| && m1.getPriority() >= m2.getPriority()) { |
There was a problem hiding this comment.
I dont see how m1.getPriority() >= m2.getPriority() can happen if it was already comfirmed that both ==0
There was a problem hiding this comment.
No, it can not happen. that was my first implementation, then I change to only check if both are 0. I don't want to risk modify this in case the users have configured priority.
There was a problem hiding this comment.
I guess the best would be to have a separate priority implementation for class hierarchy to avoid interfere with the user configuration.
There was a problem hiding this comment.
Well, the >= test will always be true, so it can be removed.
martinaldrin
changed the title
2 tasks
|
I close this PR since it was just a Proof of Concept, will continue in #2666 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Restore Ordering for DependsOnGroups by using Priority on Configuration Methods
Fixes # .
Did you remember to?
CHANGES.txtWe encourage pull requests that:
If your pull request involves fixing SonarQube issues then we would suggest that you please discuss this with the
TestNG-dev before you spend time working on it.