feat/CUS-8412-Corrected endIndex usage in GetSubStringFromStartIndexToEndIndex

[akhil-testsigma]

Publish this addon as public

Addon Name: String Data Generators
Jarvis Link: https://jarvis.testsigma.com/ui/tenants/30397/addons
Jira : https://testsigma.atlassian.net/browse/CUS-8412
Corrected endIndex usage in GetSubStringFromStartIndexToEndIndex

Summary by CodeRabbit

• Bug Fixes

  • Fixed substring extraction to correctly apply the specified end boundary instead of incorrectly using the start boundary.

• Chores

  • Updated project version to 1.0.9.

[coderabbitai]

Walkthrough

The PR updates the Maven project version from 1.0.7 to 1.0.9 and fixes a bug in the GetSubStringFromStartIndexToEndIndex class where the end index parameter was incorrectly being parsed from the start index variable.

Changes

Cohort / File(s)	Change Summary
Version Update string_data_generators/pom.xml	Updated project version from 1.0.7 to 1.0.9
Bug Fix string_data_generators/src/main/java/com/testsigma/addons/string_utils/generators/GetSubStringFromStartIndexToEndIndex.java	Fixed incorrect variable binding where tillIndex was parsed from startIndex instead of endIndex, ensuring substring uses the correct end boundary

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

• Verify the variable assignment fix in GetSubStringFromStartIndexToEndIndex is correctly sourcing from endIndex
• Ensure substring boundary logic produces expected behavior with the corrected end index
• Confirm version bump aligns with release notes

Suggested reviewers

• Ganesh-Testsigma
• vigneshtestsigma

Poem

🐰 A substring slipped through the code so neat,
Till index confused, the fix incomplete,
Now endIndex shines where it should belong,
Version bumped up—the rabbit's song!
🥕✨

Pre-merge checks and finishing touches

✅ Passed checks (2 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately reflects the main change: fixing the endIndex usage bug in GetSubStringFromStartIndexToEndIndex, which aligns with the primary fix in the changeset.

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch feat/CUS-8412-Corrected-endIndex-usage-in-GetSubStringFromStartIndexToEndIndex

---

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 99ce8c2 and 747acd0.

📒 Files selected for processing (2)

• string_data_generators/pom.xml (1 hunks)
• string_data_generators/src/main/java/com/testsigma/addons/string_utils/generators/GetSubStringFromStartIndexToEndIndex.java (1 hunks)

🔇 Additional comments (3)

string_data_generators/pom.xml (1)

9-9: Verify the version skip from 1.0.7 to 1.0.9.

The version was bumped from 1.0.7 to 1.0.9, skipping 1.0.8. While this might be intentional (e.g., 1.0.8 was used for an internal or failed release), please confirm that this is the correct versioning strategy.

string_data_generators/src/main/java/com/testsigma/addons/string_utils/generators/GetSubStringFromStartIndexToEndIndex.java (2)

23-23: Excellent bug fix!

The correction to parse tillIndex from endIndex instead of startIndex fixes a critical logic error. Previously, both indices were incorrectly sourced from startIndex, which would have resulted in incorrect substring extraction.

---

20-26: Verify unit test coverage for this bug fix.

Ensure that unit tests exist to validate the corrected behavior and prevent regression. Tests should cover:

• Normal cases with valid start and end indices
• Edge cases like startIndex == 0, endIndex == string.length()
• The specific scenario that would have failed before this fix (where startIndex != endIndex)

Warning

Review ran into problems

🔥 Problems

Git: Failed to clone repository. Please run the @coderabbitai full review command to re-trigger a full review. If the issue persists, set path_filters to include or exclude specific files.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}