fix: chrome extension with Brave flatpack#571
Open
kdihalas wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request adds support for Brave Browser installed as a Flatpak on Linux, ensuring that native messaging works correctly in sandboxed environments. It introduces a Flatpak-aware wrapper script for Brave Flatpak, updates the manifest generation logic, and thoroughly tests the new behavior.
Changes
pearpass-wrapper.sh).buildFlatpakBrowserWrapperContentinelectron/nativeHostWrapper.cjsto generate a Flatpak-aware wrapper script, handling both regular and PearPass Flatpak cases.Testing Notes
Added comprehensive tests for the new wrapper logic and updated all relevant test cases to reflect the additional Brave Flatpak target, including manifest counts and file writes. [1] [2] [3] [4] [5]
Run a functional test on Linux with Brave Flatpack
These changes ensure that PearPass integrates seamlessly with Brave Flatpak, maintaining robust native messaging support across more Linux environments.