fdroid related changes#396
Conversation
…ude build cache directory
…ilds and update documentation for clarity.
|
@nickgr2 please review this pr |
nickgr2
left a comment
There was a problem hiding this comment.
A few non-blocking observations on the build script and metadata changes.
Wiring — confirm intent
scripts/fdroid/build-bare-from-source.sh isn't invoked by scripts/fdroid-build.sh or any npm run script in the repo. Presumably the F-Droid recipe in fdroiddata calls it directly between npm ci and gradle's preBuild (the script reads from node_modules/bare-link and writes prebuilds back into node_modules/<addon>/prebuilds/ for link.mjs to pick up). Confirming this is intentional and won't get orphaned.
minor: prereq check is incomplete
discover_addons reads node_modules/bare-link/lib/dependencies (script line 379), but check_prereqs only validates react-native-bare-kit. bare-link is currently hoisted as a transitive of react-native-bare-kit@0.13.0 — if a future kit upgrade changes its dep tree, the script would fail with MODULE_NOT_FOUND from Node rather than the cleaner fatal message. A one-liner near the other directory checks — [ -d "$PROJECT_DIR/node_modules/bare-link" ] || fatal "bare-link missing; run 'npm ci' first" — would keep diagnostics consistent.
minor: changelog covers only two ABIs
metadata/en-US/changelogs/16101.txt and 16102.txt match the per-ABI versionCode scheme from scripts/fdroid-build.sh (versionCode * 10 + abiOffset, armeabi-v7a=1, arm64-v8a=2). x86 and x86_64 (offsets 3, 4) get no changelog. If the F-Droid recipe ships only the two arm ABIs that's fine; otherwise emulator users would see an empty release-notes panel.
minor: dropped F-Droid build notes from full description
The previous full_description.txt ended with a paragraph noting that the Android "fdroid" channel removes Play Services–specific auth dependencies and disables in-app version checking / Play Store redirects. That's useful context for users comparing this build to the Play Store version (different feature set on the same app page). Worth keeping it (or compressing to a "What's different on F-Droid" line) rather than removing outright.
Wiringconfirmed intentional. prereq checkGood catch, fixed covers only two ABIsIntentional. dropped F-Droid build notes from full descriptionAcknowledged, but keeping the description as-is for now. |
…roceeding with the build process.
added script for building bare from sources, required by fdroid.
added new metadata for fdroid.