QVAC-22733 feat: export CodeScan findings as a downloadable artifact + consolidated report#13
Draft
GSServita wants to merge 1 commit into
Draft
QVAC-22733 feat: export CodeScan findings as a downloadable artifact + consolidated report#13GSServita wants to merge 1 commit into
GSServita wants to merge 1 commit into
Conversation
…+ consolidated report Add an opt-out export-report input (default true) and report-retention-days to the canonical reusable security workflow. The codeql job now uploads per-language SARIF, and a new report job consolidates it into findings.json + findings.md, uploaded as a single security-scan-report artifact for offline triage / LLM-assisted ticket drafting. Purely additive: pass/fail semantics are unchanged. No secret material is ever written to any artifact (TruffleHog matches excluded by design). Documents the new inputs in docs/security-baseline.md.
Review StatusCurrent Status: ❌ PENDING Pending reviews: Needs 1 Management or Team Lead, and 1 more from Management, Team Lead, or Member. |
License compliance — findings detected (warn-only)Critical: 0 · High: 2 · Medium: 0
How to resolve a blocking finding:
Warn-only (shadow) mode — this check does not block merges yet. Updated automatically by the canonical license compliance workflow. NOTICE presence (advisory)Missing NOTICE (advisory, does not block):
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎯 What problem does this PR solve?
codeql-upload: never(e.g.qvacon Default setup) they don't surface anywhere consumable at all.📝 How does it solve it?
export-reportinput (defaulttrue) plusreport-retention-daysto the reusablepublic-reusable-security.yml.codeqljob now uploads its per-language SARIF ascodeql-sarif-<language>artifacts (even when the severity gate fails).reportjob consolidates all SARIF intofindings.json(flat array: rule, level, security-severity, file, line, message) plus a human/LLM-readablefindings.md, uploaded as a singlesecurity-scan-reportartifact.codeql-upload: neverrepos, whose findings are otherwise invisible.docs/security-baseline.md.🧪 How was it tested?
actionlintclean on the modifiedpublic-reusable-security.yml.security-self-test*callers exercise it end-to-end; will confirm thesecurity-scan-reportartifact appears (findings.json+findings.md) and contains no secret values before marking ready for review.0.3.0, then bump theqvaccaller pin (which also gains a weeklyschedule).🔐 Action pinning
Two artifact actions newly referenced, pinned to SHA + version comment (matching the org's existing pins in
tetherto/qvac):actions/upload-artifact: addedbbbca2ddaa5d8feaa63e36b76fdaad77386f024f # 7.0.0actions/download-artifact: added3e5f45b2cfb9172054b4087a40e8e0b5a5461e7c # 8.0.1🛡️ Permissions changes
report(new)contents: readsecurity-eventsorpull-requestswrite. Least privilege.