Add CODEOWNERS and approval-check-worker workflow (DEVOPS-2152)#2
Open
fexhniov wants to merge 1 commit into
Open
Add CODEOWNERS and approval-check-worker workflow (DEVOPS-2152)#2fexhniov wants to merge 1 commit into
fexhniov wants to merge 1 commit into
Conversation
Prerequisite for the branch protection ruleset being applied to this repo via tetherto/data-github-ops#371. The ruleset (mirrored from qvac-fabric-llm.cpp) gates merges on the "Tier-based Approval Check" status produced by this workflow, and requires code owner review. Without these files in place first, every PR to main/master would be permanently blocked.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds two files required as a prerequisite for the branch protection ruleset being applied to this repo via tetherto/data-github-ops#371:
.github/CODEOWNERS—* @tetherto/ai-runtime-bk-models(mirrorsqvac-fabric-llm.cpp). Required because the incoming ruleset enforcesrequire_code_owner_review. Reviewer: please confirmai-runtime-bk-modelsis the right owning team for this repo, or suggest the correct one..github/workflows/approval-check-worker.yml— produces theTier-based Approval Checkstatus that the ruleset will require. Identical to the workflow currently running onqvac-fabric-llm.cpp(usespull_request_reviewtriggers, referencestetherto/qvac-devops/.github/workflows/approval-check-worker.yml@production-workflows-tag).Without these in place first, the ruleset PR (tetherto/data-github-ops#371) would permanently block every PR to
main/masterwaiting on a status that never reports, and on a CODEOWNERS file that doesn't exist.Merge order
Test plan
ai-runtime-bk-modelsis the correct CODEOWNERS team for this repo (or update before merge).Approval Check Workerworkflow on review submit/dismiss.