QVAC-18827 feat[bc|api]: add unloadModel autoClose option, default-off on Bare#2024
Merged
opaninakuffo merged 3 commits intoMay 13, 2026
Merged
Conversation
QVAC E2E —
|
QVAC E2E —
|
simon-iribarren
approved these changes
May 13, 2026
NamelsKing
approved these changes
May 13, 2026
Contributor
Author
|
review |
Tier-based Approval Status |
Contributor
Author
|
review |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎯 What problem does this PR solve?
unloadModelcallsclose()unconditionally when no models/providers remain, which terminates long-lived Bare worker hosts on every routine unload.unloadModelor work around the auto-close.📝 How does it solve it?
autoClose: booleanparam tounloadModel.which-runtime.isBare:trueon Node/Electron (preserves current behavior),falseon Bare (worker survives unload).autoClose: true | falsealways wins.unloadModelRequestSchema) is unchanged, no server changes needed.🧪 How was it tested?
Two-runtime integration smoke against
examples/quickstart.ts(load → completion → unload):gtimeoutcap)Model … unloadedserver log🧹 No models or providers active, automatically closing RPC connection…Last row is the verdict: auto-close branch fires on Bun, skipped on Bare.
eslint,tsc --noEmit, andbun run buildall clean.💥 Breaking Changes
Bare consumers no longer have their host process closed by
unloadModel. Node/Electron behavior is unchanged.BEFORE: (Bare)
AFTER: (Bare)
🔌 API Changes