Skip to content

QVAC-18460 test[skiplog]: re-enable iOS transcription tests#2025

Merged
Victor-Rodzko merged 2 commits into
mainfrom
qvac-18460-reenable-ios-transcription-tests
May 13, 2026
Merged

QVAC-18460 test[skiplog]: re-enable iOS transcription tests#2025
Victor-Rodzko merged 2 commits into
mainfrom
qvac-18460-reenable-ios-transcription-tests

Conversation

@Victor-Rodzko
Copy link
Copy Markdown
Contributor

@Victor-Rodzko Victor-Rodzko commented May 13, 2026

🎯 What problem does this PR solve?

📝 How does it solve it?

  • Drops the four iOS-only SkipExecutor / skipTests(...) entries in tests/mobile/consumer.ts that referenced TODO(QVAC-18460).
  • No other behavioural change — the executors and test definitions were already in place; only the iOS skip filters are gone.

🧪 How was it tested?

  • Re-runs the iOS mobile workflow on this PR, which now exercises the full transcription family (previously skipped) on Device Farm.
  • Tested locally on iOS (iphone 16e) - all 21 passed

The native iOS transcribe() crash (Mach exception 309 after FFmpegDecoder
unload) was fixed by the whisper.cpp bump to @qvac/transcription-whispercpp
^0.7.0 (#2015). Remove the iOS skip filters for transcription-*,
transcribe-stream-events-*, addon-logging-whisper, config-reload-then-transcribe
and error-transcription-failed so iOS smoke covers the full transcription
surface again.

Co-authored-by: Cursor <cursoragent@cursor.com>
@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 13, 2026

QVAC E2E — windows — ✅ all tests passed (91/91, 439s)

Config: suite=smoke · filter=(none) · exclude=(none)
View run · Artifacts: reports

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 13, 2026

QVAC E2E — android — ✅ all tests passed (83/91, 2454s)

Config: suite=smoke · filter=(none) · exclude=(none)
View run · Artifacts: reports · Device Farm logs

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 13, 2026

QVAC E2E — linux — ✅ all tests passed (91/91, 360s)

Config: suite=smoke · filter=(none) · exclude=(none)
View run · Artifacts: reports

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 13, 2026

QVAC E2E — macos — ✅ all tests passed (91/91, 351s)

Config: suite=smoke · filter=(none) · exclude=(none)
View run · Artifacts: reports

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 13, 2026

QVAC E2E — ios — ❌ failed

Totals: 81/91 passed · 1 failed · 98.8% · 1638s
Config: suite=smoke · filter=(none) · exclude=(none)
View run · Artifacts: reports · Device Farm logs

Results by section

  • addon-logging: 1/2 ❌

Failed tests

  • addon-logging-during-inference: Test timeout after 120s

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 13, 2026

Tier-based Approval Status

**PR Tier:** TIER1

**Current Status:** ✅ APPROVED

**Requirements:**
- 1 Team Member approval ✅ (1/1)
- 1 Team Lead OR Management approval ✅ (1/1)



---
*This comment is automatically updated when reviews change.*

@github-actions github-actions Bot added the e2e-tested Test suite has run on this PR. Does not indicate tests pass/fail - see results in comments. label May 13, 2026
@kinsta
Copy link
Copy Markdown

kinsta Bot commented May 13, 2026

Preview deployments for qvac-docs-staging ⚡️

Status Branch preview Commit preview
🔁 Deploying... N/A N/A

Commit: 848816aad13784e53aef8e3e57e07e27819d1782

Deployment ID: 8c955b2e-5913-46f2-9a57-edb87aa14442

Static site name: qvac-docs-staging-fazwv

@Victor-Rodzko Victor-Rodzko merged commit 7ed7243 into main May 13, 2026
23 checks passed
@Victor-Rodzko Victor-Rodzko deleted the qvac-18460-reenable-ios-transcription-tests branch May 13, 2026 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

e2e-tested Test suite has run on this PR. Does not indicate tests pass/fail - see results in comments. test-e2e-smoke Triggers smoke e2e test suite [Currently SDK-only] tier1 verify

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants