QVAC-18612 test[notask]: validate merged label-gate fan-out (will be closed)#2048
QVAC-18612 test[notask]: validate merged label-gate fan-out (will be closed)#2048Proletter wants to merge 1 commit into
Conversation
No-op README edit to validate the merged label-gate fan-out (PR #2023). Will be closed after observation. Co-authored-by: Cursor <cursoragent@cursor.com>
✅ Validation complete —
|
| Workflow | label-gate result | Downstream gated jobs |
|---|---|---|
On PR Trigger (LLM) (run) |
authorised=false ('verified' label is not currently applied to PR #2048) |
SKIPPED ✓ |
On PR Trigger (Embed) (run) |
authorised=false |
SKIPPED ✓ |
Build and Publish QVAC SDK (run) |
authorised=false |
SKIPPED ✓ |
QVAC Tests (sdk) - PR (run) |
authorised=false |
SKIPPED ✓ |
20 secret-bearing jobs correctly skipped. Zero caller-cap validation errors.
Phase 2: verified label applied by trusted maintainer
| Workflow | label-gate result | Reusable callees |
|---|---|---|
On PR Trigger (LLM) (run) |
authorised=true (label applier 'Proletter' is trusted (member of 'tetherto/qvac-internal-dev')) |
cpp-lint, cpp-tests (4 platforms), prebuild (9 platforms) — all started, queued for self-hosted runners |
On PR Trigger (Embed) (run) |
authorised=true |
Same — all started ✓ |
Build and Publish QVAC SDK (run) |
authorised=true |
build reusable started ✓ |
Other gated jobs that don't need self-hosted runners completed successfully: ts-checks, verify-fabric-lockstep, sanity-checks.
Critical proof: the #1997 failure mode is fixed
Reusable workflow invocations like cpp-lint, cpp-tests, prebuild, build are visible as jobs in the runs (queued for runners). This proves:
- The workflow file passed GitHub's caller-cap validation.
- The reusable callees were successfully started by the gated caller.
- No
Error calling workflow ... The nested job 'label-gate' is requesting 'pull-requests: write', but is only allowed 'pull-requests: none'errors anywhere.
This is the exact failure mode that broke #1997 on test PR #2017. The architectural fix shipped in #2023 (caller-gates-callee, reusable callees byte-identical to main) holds in production.
Bonus: label was NOT stripped
verified label still applied on this PR after Phase 2. Confirms my user (Proletter via team qvac-internal-dev) is recognised as trusted — the unauthorised-applier strip path was correctly not triggered.
Closing this PR — pure validation, no changes intended for main.
Tier-based Approval Status |
Purpose
Runtime validation of the merged PR #2023 (
label-gatefan-out). This PR will be closed without merging after the validation matrix passes.What this PR triggers
Trivial README appends to:
packages/embed-llamacpp/README.md→ triggerson-pr-embed-llamacpp.ymlpackages/llm-llamacpp/README.md→ triggerson-pr-llm-llamacpp.ymlpackages/sdk/README.md→ triggerson-pr-test-sdk.yml,pr-checks-sdk-pod.yml,pr-validation-sdk-pod.ymlValidation matrix (mirrors qvac-internal#12)
verifiedlabellabel-gatejobs reportauthorised=false; downstream secret-bearing jobs SKIPPEDverifiedlabel applied by trusted maintainer (Olutest, member ofqvac-internal-{dev,merge,release})label-gatejobs reportauthorised=true; downstream gated jobs RUN; no caller-cap validation errors (the #1997 failure mode)integration-test-llm-llamacpp.yml,integration-test-embed-llamacpp.yml, etc.) execute viaif: needs.label-gate.outputs.authorised == 'true'from callerIf all three pass, this validates the architectural fix shipped in #2023.
Refs: QVAC-18612.
Made with Cursor