Skip to content

QVAC-2444 fix: surface worker startup stderr#2550

Merged
yuranich merged 4 commits into
tetherto:mainfrom
yuranich:issue-2444-worker-error-repro
Jun 15, 2026
Merged

QVAC-2444 fix: surface worker startup stderr#2550
yuranich merged 4 commits into
tetherto:mainfrom
yuranich:issue-2444-worker-error-repro

Conversation

@yuranich

@yuranich yuranich commented Jun 11, 2026

Copy link
Copy Markdown
Contributor

🎯 What problem does this PR solve?

  • Native addon and Bare worker startup failures were visible only in child-process stderr.
  • SDK callers saw a generic RPC_INIT_TIMEOUT error, which made failures like missing native libraries hard to diagnose from application code.

📝 How does it solve it?

  • Captures a bounded tail of Bare worker stderr during Node worker startup.
  • Preserves the existing RPC_INIT_TIMEOUT error class while attaching the captured worker stderr to the error cause for pre-handshake failures.
  • Adds unit coverage with loadModel() and a failing worker fixture for startup failure diagnostics.

🧪 How was it tested?

  • bun run build
  • bun run test/unit/worker-startup-error.test.ts
  • bun run test/unit/worker-close-clean.test.ts

@yuranich yuranich marked this pull request as ready for review June 12, 2026 07:20
@yuranich yuranich requested review from a team as code owners June 12, 2026 07:20

@lauripiisang lauripiisang left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just one note about a possible race.

Comment thread packages/sdk/client/rpc/node-rpc-client.ts
@yuranich yuranich force-pushed the issue-2444-worker-error-repro branch from 50752e5 to 431430f Compare June 12, 2026 12:50
@yuranich yuranich requested a review from lauripiisang June 12, 2026 13:20
yuranich and others added 2 commits June 12, 2026 19:25
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
@yuranich yuranich force-pushed the issue-2444-worker-error-repro branch from 431430f to cee4ecc Compare June 12, 2026 13:25
@yuranich

Copy link
Copy Markdown
Contributor Author

/review

@github-actions

Copy link
Copy Markdown
Contributor

Tier-based Approval Status

**PR Tier:** TIER1

**Current Status:** ✅ APPROVED

**Requirements:**
- 1 Team Member approval ✅ (1/1)
- 1 Team Lead OR Management approval ✅ (1/1)



---
*This comment is automatically updated when reviews change.*

@yuranich yuranich merged commit bf2fcd2 into tetherto:main Jun 15, 2026
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants