QVAC-17907 chore: adopt canonical model type names in SDK docs, examples, and tests#2623
Merged
Merged
Conversation
4ce7040 to
3c6f7a5
Compare
3c6f7a5 to
6dd3a61
Compare
6dd3a61 to
ed51a4c
Compare
ed51a4c to
90f3deb
Compare
Contributor
QVAC E2E —
|
Contributor
Contributor
Contributor
Contributor
QVAC E2E —
|
opaninakuffo
approved these changes
Jun 18, 2026
lauripiisang
approved these changes
Jun 18, 2026
Signed-off-by: Arun Mani J <j.arunmani@proton.me>
90f3deb to
5880148
Compare
Contributor
Author
|
review |
Contributor
Tier-based Approval Status |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎯 What problem does this PR solve?
loadModelreference docs, an example, and assorted tests. These aliases are deprecated (they log a warning and normalize to canonical), so teaching them weakens API clarity.📝 How does it solve it?
modelTypeentirely — it's inferred from theLLAMA_3_2_1B_INST_Q4_0registry descriptor'sengine— demonstrating the preferred descriptor-driven pattern.client/api/load-model.tsTSDoc (param doc + all@exampleblocks) uses canonical names and notesmodelTypemay be omitted for registry descriptors. This TSDoc generates the published API reference.examples/diffusion-img2vid.ts:"diffusion"→"sdcpp-generation"(kept explicit sincemodelSrccan be a plain CLI path with no metadata).schemas/model-types.tsdocstring leads with the canonical accessor and labels the alias as deprecated.bci/vla/classification/sdcpp/profiler/inference-handler-migrationsand thepr-body-bc-validfixture. Left aliases only in the five tests that specifically verify the alias mechanism (accepts alias / resolves alias / rejects alias for plugins).addonsearch facet (a separate taxonomy incl.vad/other) is untouched.🧪 How was it tested?
bun run build— lint, typecheck, compile clean.bun run test:unit— all files pass.bun run test:bare— 43/43 tests, 207/207 asserts pass.