Skip to content

fix[notask]: clean up Expo RPC worker on non-iOS close#2639

Merged
opaninakuffo merged 3 commits into
tetherto:mainfrom
DarkJoker360:expo-rpc-non-ios-cleanup
Jun 18, 2026
Merged

fix[notask]: clean up Expo RPC worker on non-iOS close#2639
opaninakuffo merged 3 commits into
tetherto:mainfrom
DarkJoker360:expo-rpc-non-ios-cleanup

Conversation

@DarkJoker360

Copy link
Copy Markdown
Contributor

🎯 What problem does this PR solve?

  • Expo app reset/reload flows on non-iOS platforms can leave addon logger JS references held by the worker.
  • A fresh worker in the same app process can then register plugins while stale handles are still alive.

📝 How does it solve it?

  • Sends the worker shutdown cleanup roundtrip on non-iOS before dropping RPC references.
  • Keeps Android safe by avoiding worklet termination/dlclose while still releasing worker-side addon handles.

🧪 How was it tested?

  • Not run; source-only cleanup path change.

@DarkJoker360 DarkJoker360 requested review from a team as code owners June 16, 2026 15:20
@opaninakuffo opaninakuffo added test-e2e-smoke Triggers smoke e2e test suite [Currently SDK-only] verified Authorize secrets / label-gate in PR workflows labels Jun 16, 2026
@opaninakuffo opaninakuffo added test-e2e-smoke Triggers smoke e2e test suite [Currently SDK-only] and removed test-e2e-smoke Triggers smoke e2e test suite [Currently SDK-only] labels Jun 17, 2026
@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@opaninakuffo opaninakuffo added test-e2e-smoke Triggers smoke e2e test suite [Currently SDK-only] and removed test-e2e-smoke Triggers smoke e2e test suite [Currently SDK-only] labels Jun 18, 2026
@github-actions

github-actions Bot commented Jun 18, 2026

Copy link
Copy Markdown
Contributor

QVAC E2E — ios — ✅ all tests passed (84/98, 921s)

Config: suite=smoke · filter=(none) · exclude=(none)
View run · Artifacts: reports · Device Farm logs

@github-actions

github-actions Bot commented Jun 18, 2026

Copy link
Copy Markdown
Contributor

QVAC E2E — android — ✅ all tests passed (86/98, 2739s)

Config: suite=smoke · filter=(none) · exclude=(none)
View run · Artifacts: reports · Device Farm logs

@github-actions

github-actions Bot commented Jun 18, 2026

Copy link
Copy Markdown
Contributor

QVAC E2E — windows — ✅ all tests passed (98/98, 398s)

Config: suite=smoke · filter=(none) · exclude=(none)
View run · Artifacts: reports

@github-actions

github-actions Bot commented Jun 18, 2026

Copy link
Copy Markdown
Contributor

QVAC E2E — linux⚠️ no results

Config: suite=smoke · filter=(none) · exclude=(none)
View run

The test job did not produce a results artifact. Check the run for job-level failures.

@github-actions

github-actions Bot commented Jun 18, 2026

Copy link
Copy Markdown
Contributor

QVAC E2E — macos — ✅ all tests passed (98/98, 280s)

Config: suite=smoke · filter=(none) · exclude=(none)
View run · Artifacts: reports

@opaninakuffo

Copy link
Copy Markdown
Contributor

review

@github-actions

Copy link
Copy Markdown
Contributor

Tier-based Approval Status

**PR Tier:** TIER1

**Current Status:** ✅ APPROVED

**Requirements:**
- 1 Team Member approval ❌ (0/1)
- 1 Team Lead OR Management approval ✅ (2/1)

**Bypass rule:** Triggered (2+ Team Lead approvals (Tier 1 exception)). This PR is approved regardless of tier.

---
*This comment is automatically updated when reviews change.*

@opaninakuffo opaninakuffo merged commit b198526 into tetherto:main Jun 18, 2026
18 checks passed
opaninakuffo added a commit to opaninakuffo/qvac that referenced this pull request Jun 18, 2026
* fix: clean up Expo RPC worker on non-iOS close

* fix: reset Expo RPC worklet after non-iOS close

Co-authored-by: Cursor <cursoragent@cursor.com>

---------

Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Opanin Akuffo <46673050+opaninakuffo@users.noreply.github.com>
(cherry picked from commit b198526)
opaninakuffo added a commit that referenced this pull request Jun 18, 2026
…er on non-iOS close (#2692)

* fix[notask]: clean up Expo RPC worker on non-iOS close (#2639)

* fix: clean up Expo RPC worker on non-iOS close

* fix: reset Expo RPC worklet after non-iOS close

Co-authored-by: Cursor <cursoragent@cursor.com>

---------

Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Opanin Akuffo <46673050+opaninakuffo@users.noreply.github.com>
(cherry picked from commit b198526)

* chore[notask]: release sdk + bare-sdk 0.13.5 — clean up Expo RPC worker on non-iOS close

---------

Co-authored-by: Simone Esposito <31246543+DarkJoker360@users.noreply.github.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

test-e2e-smoke Triggers smoke e2e test suite [Currently SDK-only] verified Authorize secrets / label-gate in PR workflows

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants