QVAC-20946 fix: classification plugin bundling and mobile e2e coverage#2663
Merged
Conversation
Co-authored-by: Cursor <cursoragent@cursor.com>
Contributor
QVAC E2E —
|
Contributor
Contributor
Contributor
Contributor
QVAC E2E —
|
arun-mani-j
approved these changes
Jun 18, 2026
Contributor
Tier-based Approval Status |
opaninakuffo
approved these changes
Jun 18, 2026
Contributor
Author
|
/review |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎯 What problem does this PR solve?
@qvac/sdk/ggml-classification/pluginas a built-in plugin, so config-string bundling could treat it as a custom default-export plugin instead of using the namedclassificationPluginexport.@qvac/classification-ggmlMobileNet GGUF weights were not available at the package-relative path used inside the Bare worker bundle.📝 How does it solve it?
ggml-classificationto the SDK bundler built-in plugin map so worker entry generation importsclassificationPluginby name.classificationTestsin the e2e test catalog..gguffiles as Metro assets and resolves the bundled classification weights on mobile, passing the real asset path throughmodelConfig.modelPath.🧪 How was it tested?
npm run buildinpackages/sdk/e2e.npx qvac-test run:local:ios --filter classification-passed 4/4 tests inpackages/sdk/e2e/reports/local-local-1781703528426.