Skip to content

QVAC-20946 fix: classification plugin bundling and mobile e2e coverage#2663

Merged
Victor-Rodzko merged 2 commits into
mainfrom
fix/mobile-classification-e2e
Jun 18, 2026
Merged

QVAC-20946 fix: classification plugin bundling and mobile e2e coverage#2663
Victor-Rodzko merged 2 commits into
mainfrom
fix/mobile-classification-e2e

Conversation

@Victor-Rodzko

@Victor-Rodzko Victor-Rodzko commented Jun 17, 2026

Copy link
Copy Markdown
Contributor

🎯 What problem does this PR solve?

  • SDK bundle generation did not recognize @qvac/sdk/ggml-classification/plugin as a built-in plugin, so config-string bundling could treat it as a custom default-export plugin instead of using the named classificationPlugin export.
  • Mobile SDK e2e classification coverage was not included in the shared test catalog.
  • When classification tests were run manually on mobile, setup failed because the bundled @qvac/classification-ggml MobileNet GGUF weights were not available at the package-relative path used inside the Bare worker bundle.

📝 How does it solve it?

  • Adds ggml-classification to the SDK bundler built-in plugin map so worker entry generation imports classificationPlugin by name.
  • Registers classificationTests in the e2e test catalog.
  • Treats .gguf files as Metro assets and resolves the bundled classification weights on mobile, passing the real asset path through modelConfig.modelPath.

🧪 How was it tested?

  • npm run build in packages/sdk/e2e.
  • Local iOS mobile classification run: npx qvac-test run:local:ios --filter classification- passed 4/4 tests in packages/sdk/e2e/reports/local-local-1781703528426.

Co-authored-by: Cursor <cursoragent@cursor.com>
@Victor-Rodzko Victor-Rodzko requested review from a team as code owners June 17, 2026 14:06
@Victor-Rodzko Victor-Rodzko changed the title fix[notask]: run classification e2e on mobile QVAC-20946 fix: run classification e2e on mobile Jun 17, 2026
@Victor-Rodzko Victor-Rodzko changed the title QVAC-20946 fix: run classification e2e on mobile QVAC-20946 fix: classification plugin bundling and mobile e2e coverage Jun 17, 2026
@Victor-Rodzko Victor-Rodzko added verified Authorize secrets / label-gate in PR workflows test-e2e-smoke Triggers smoke e2e test suite [Currently SDK-only] labels Jun 17, 2026
@github-actions

github-actions Bot commented Jun 17, 2026

Copy link
Copy Markdown
Contributor

QVAC E2E — ios — ✅ all tests passed (86/100, 985s)

Config: suite=smoke · filter=(none) · exclude=(none)
View run · Artifacts: reports · Device Farm logs

@github-actions

github-actions Bot commented Jun 17, 2026

Copy link
Copy Markdown
Contributor

QVAC E2E — windows — ✅ all tests passed (100/100, 371s)

Config: suite=smoke · filter=(none) · exclude=(none)
View run · Artifacts: reports

@github-actions

github-actions Bot commented Jun 17, 2026

Copy link
Copy Markdown
Contributor

QVAC E2E — linux — ❌ failed

Totals: 99/100 passed · 1 failed · 99.0% · 583s
Config: suite=smoke · filter=(none) · exclude=(none)
View run · Artifacts: reports

Results by section

  • translation-indictrans: 1/2 ❌

Failed tests

  • translation-indictrans-en-hi-basic: Test timeout after 120s

@github-actions

github-actions Bot commented Jun 17, 2026

Copy link
Copy Markdown
Contributor

QVAC E2E — macos — ✅ all tests passed (100/100, 268s)

Config: suite=smoke · filter=(none) · exclude=(none)
View run · Artifacts: reports

@github-actions

github-actions Bot commented Jun 17, 2026

Copy link
Copy Markdown
Contributor

QVAC E2E — android — ✅ all tests passed (88/100, 2694s)

Config: suite=smoke · filter=(none) · exclude=(none)
View run · Artifacts: reports · Device Farm logs · Device Farm logs

@github-actions

github-actions Bot commented Jun 18, 2026

Copy link
Copy Markdown
Contributor

Tier-based Approval Status

**PR Tier:** TIER1

**Current Status:** ✅ APPROVED

**Requirements:**
- 1 Team Member approval ✅ (1/1)
- 1 Team Lead OR Management approval ✅ (1/1)



---
*This comment is automatically updated when reviews change.*

@Victor-Rodzko

Copy link
Copy Markdown
Contributor Author

/review

@Victor-Rodzko Victor-Rodzko merged commit 5709369 into main Jun 18, 2026
25 checks passed
@Victor-Rodzko Victor-Rodzko deleted the fix/mobile-classification-e2e branch June 18, 2026 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

test-e2e-smoke Triggers smoke e2e test suite [Currently SDK-only] verified Authorize secrets / label-gate in PR workflows

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants