chore: wire in lunte and prettier-config-holepunch for classification-ggml#2746
Open
donriddo wants to merge 1 commit into
Open
chore: wire in lunte and prettier-config-holepunch for classification-ggml#2746donriddo wants to merge 1 commit into
donriddo wants to merge 1 commit into
Conversation
…-ggml Replace standard with lunte for linting and prettier with prettier-config-holepunch for formatting. lint runs prettier --check then lunte; a new format script runs prettier --write. Swaps the standard devDependency for lunte, prettier and prettier-config-holepunch and adds the prettier and lunte config files. No formatting is applied here, so prettier --check stays red until the owning team runs npm run format. .lunterc downgrades eqeqeq, no-var, curly, no-unused-vars and prefer-const to warnings to match standard effective behaviour.
Contributor
Review StatusCurrent Status: ❌ PENDING Pending reviews: Needs 1 Management or Team Lead, and 1 more from Management, Team Lead, or Member. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎯 What problem does this PR solve?
standardwithluntefor linting andprettierwithprettier-config-holepunchfor formatting. Part of the repo-wide migration, done package by package.📝 How does it solve it?
lintnow runsprettier --checkfollowed bylunte; a newformatscript runsprettier --write. Scope mirrors whatstandardcovered.standarddevDependency forlunte,prettier,prettier-config-holepunch; adds.prettierrc,.prettierignore,.lunterc,.lunteignore; removes anystandardignore config.prettier --check(and therefore CI lint) will be red until the owning team runsnpm run format(a single command). This is intentional, so each team applies and reviews its own formatting..luntercdowngradeseqeqeq,no-var,curly,no-unused-varsandprefer-constto warnings, becauselunteis stricter thanstandardon those (standard allows the== nullidiom and ignores unused arguments). This keeps the tooling swap free of behavioural code edits.🧪 How was it tested?
luntepasses on the current code;prettier --checkis red by design until the code is formatted withnpm run format.standardreference remains in the package.