QVAC-21100: Static MSVC runtime for native addons on Windows version bump#2775
Merged
gianni-cor merged 2 commits intoJun 22, 2026
Merged
Conversation
Contributor
Review StatusCurrent Status: ❌ PENDING Pending reviews: Needs 1 Management or Team Lead, and 1 more from Management, Team Lead, or Member. |
gianni-cor
previously approved these changes
Jun 22, 2026
gianni-cor
approved these changes
Jun 22, 2026
donriddo
approved these changes
Jun 22, 2026
pratiknarola-t
added a commit
that referenced
this pull request
Jun 22, 2026
…st main (DO NOT MERGE) Rebase per team lead: #2734 was stale (on pre-#2706 main), so pull_request_target ran main's new win32 static-CRT check against my old code that still had the dynamic dependency. Reset to latest main (has #2706 d3edd34 + the win32 static-CRT fix #2722/#2775) and reapply ONLY the diag delta (packages/tts-ggml): overlay ports (ggml-speech + tts-cpp), vcpkg-configuration overlay entry, gpu-smoke corr/ capture-last measurement, correlation-helper, and the model-interface [gpu-diag] bridge + allow_arm_mali measurement. Overlays pinned to the FA fix on latest upstream: ggml-speech e303be3f = speech 7bb9f229 + subgroup-16 matmul fix + f5c6977c (f32-accumulate P*V in coopmat1 flash-attn) tts-cpp 349189e6 = whisper.cpp master f4208d2d + the diag harness + ggml_flash_attn_ext_set_prec(GGML_PREC_F32) on the 3 Supertonic FA nodes Now on latest main, win32 builds static CRT -> check passes -> device farm runs. Expect Mali text_emb ~1.0, wav_full corr >=0.99; S25/Adreno control unaffected.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumped all 14 addon packages touched by the static Windows runtime commit (
5aa6271).Patch bump (already outside SDK 0.13 range or transitive dep)
@qvac/bci-whispercpp@qvac/classification-ggml@qvac/embed-llamacpp@qvac/llm-llamacpp@qvac/translation-nmtcpp@qvac/tts-ggml@qvac/vla-ggml@qvac/transcription-parakeet@qvac/onnx@qvac/transcription-whispercppMinor bump (still within SDK 0.13 range, or no SDK dep)
@qvac/diffusion-cpp@qvac/ocr-onnx@qvac/ocr-ggml@qvac/tts-onnxDependency pins updated (same change set)
ocr-onnx/tts-onnx:@qvac/onnx^0.15.0→^0.15.1tts-ggml:@qvac/transcription-whispercpp^0.10.0→^0.10.1