fix[notask]: emit NodeNext-compatible declaration specifiers#3381
Open
localhost41 wants to merge 1 commit into
Open
fix[notask]: emit NodeNext-compatible declaration specifiers#3381localhost41 wants to merge 1 commit into
localhost41 wants to merge 1 commit into
Conversation
Contributor
Review StatusCurrent Status: ❌ PENDING Pending reviews: Needs 1 Management or Team Lead, and 1 more from Management, Team Lead, or Member. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #3323.
The SDK’s post-build alias resolver was adding
.jsextensions to runtime imports but leaving the corresponding declaration imports extensionless. UndermoduleResolution: "NodeNext", TypeScript could not follow the declaration re-export chain, so model constants appeared to be missing even though they were available at runtime.This updates the resolver to emit
.jsspecifiers for internal references in declaration output as well. It also handles parent-directory paths such as../schemas, which were still present in the generated declarations.Added a regression test that:
@qvac/sdkand@qvac/sdk/models;tscconsumer usingmoduleResolution: "NodeNext";Validated with:
Runtime JavaScript output is unchanged.