Skip to content

Update fastify to v5#8

Merged
tekwani merged 7 commits into
tetherto:mainfrom
Boka44:chore/update-fastify
May 26, 2026
Merged

Update fastify to v5#8
tekwani merged 7 commits into
tetherto:mainfrom
Boka44:chore/update-fastify

Conversation

@Boka44

@Boka44 Boka44 commented Feb 11, 2026

Copy link
Copy Markdown
Member

Comment thread package.json Outdated
Comment thread package.json Outdated
Co-authored-by: tekwani <tekwani.hemant@gmail.com>
tekwani
tekwani previously approved these changes Feb 11, 2026
tekwani
tekwani previously approved these changes Feb 11, 2026
@ehtesham1996

Copy link
Copy Markdown
Contributor

For instance this would be breaking change for dependent repo's. Either they use commit specific latest which is as of now
c2ca996f29504941a3806ddd3d7cb803f8b94de9 or they have to follow the migration guide i.e https://fastify.dev/docs/v5.4.x/Guides/Migration-Guide-V5/

@Boka44

Boka44 commented Feb 12, 2026

Copy link
Copy Markdown
Member Author

For instance this would be breaking change for dependent repo's. Either they use commit specific latest which is as of now c2ca996f29504941a3806ddd3d7cb803f8b94de9 or they have to follow the migration guide i.e https://fastify.dev/docs/v5.4.x/Guides/Migration-Guide-V5/

@ehtesham1996 We discussed making a v4 or v5 specific branch if needed.

@francesco-ubq

francesco-ubq commented Feb 16, 2026

Copy link
Copy Markdown
Contributor

Approving as per internal slack conversation / sync

francesco-ubq
francesco-ubq previously approved these changes Apr 28, 2026
@vigan-abd vigan-abd dismissed stale reviews from francesco-ubq and tekwani via 29e1430 May 8, 2026 13:44
francesco-ubq
francesco-ubq previously approved these changes May 13, 2026

@vigan-abd vigan-abd left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

update pkg lock as well

@AlexAtrx

Copy link
Copy Markdown

Running npm update --package-lock-only on this branch should refresh the lockfile cleanly.
I verified locally it adjusts package-lock.json and brings npm audit to 0 vulnerabilities (closes the 7 currently flagged on the branch: 4 high, 3 moderate).

That should cover @vigan-abd 's lockfile request.

@Boka44 could you push the refresh on chore/update-fastify?
This PR should be ready to merge once that lands.

@AlexAtrx

Copy link
Copy Markdown

@Boka44
Audit is clean now, thanks.
One small thing: rerunning npm update --package-lock-only still changes package-lock.json for me. Could you push that remaining lockfile diff too?

@tekwani tekwani merged commit a8b8668 into tetherto:main May 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants