chore: fix lint script for ci#24
Merged
jonathunne merged 1 commit intotetherto:mainfrom May 5, 2026
Merged
Conversation
jonathunne
approved these changes
May 5, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix
npm run lint, which was crashing with 8 "TSConfig does not include this file" parse errors and never actually running any rules.Root cause:
.eslintrc.jsenables type-aware linting viaparserOptions.project: './tsconfig.json', buttsconfig.jsonexcludessrc/__tests__/and*.test.ts/*.spec.tssotscdoesn't emit tests intodist/. The parser couldn't find type info for test files and bailed before linting anything.Fix: add a separate
tsconfig.eslint.json(extends base, includes tests) and point ESLint at it. The build'stsconfig.jsonis untouched, so publisheddist/output is unchanged.Changes:
tsconfig.eslint.json(new): extendstsconfig.json, includessrc/**/*, relaxesnoUnusedLocals/noUnusedParametersfor tests..eslintrc.js: points attsconfig.eslint.json(withtsconfigRootDir: __dirname); adds anoverridesblock forsrc/__tests__/**that enables thejestenv and disables type-aware rules that don't apply to tests/mocks (no-unsafe-*,no-explicit-any,require-await,unbound-method,no-extra-semi).let mockStorage→const; unusedoptionsparam →_options.Production source stays under the full strict ruleset including
recommended-requiring-type-checking.Motivation and Context
The
lintjob in.github/workflows/build.ymlruns on every PR but was crashing before it could lint anything — we had no real lint coverage. This restores it.This is the canonical "split tsconfig" pattern from the typescript-eslint docs for libraries that ship a narrower set of files than they lint.
Related Issue
PR fixes the following issue: N/A — internal CI fix.
Type of change