Feature - Sign tx#77
Merged
Merged
Conversation
Davi0kProgramsThings
previously requested changes
Apr 17, 2026
Davi0kProgramsThings
left a comment
Davi0kProgramsThings
left a comment
Contributor
There was a problem hiding this comment.
We need to update the version of wdk-wallet-evm in the package.json file so that it includes the sign transaction method.
Except for the above, the PR LGTM.
jonathunne
approved these changes
May 22, 2026
jonathunne
left a comment
jonathunne
left a comment
Contributor
There was a problem hiding this comment.
LGTM - thanks @Boka44
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add a new signTransaction method that signs a transaction and returns the raw signed transaction.
Motivation and Context
Currently, WDK only supports sendTransaction, which signs and broadcasts in one step. Some consumers want to sign a transaction locally and handle broadcasting themselves (e.g. to submit via a different relayer, queue the tx, or inspect it before sending). This new method supports that workflow while leaving sendTransaction unchanged.
Type of change