feat: implement more feature for solana wallet#76
Open
lunargon wants to merge 7 commits into
Open
Conversation
sontuphan
requested changes
Jul 20, 2026
sontuphan
left a comment
sontuphan
left a comment
Contributor
There was a problem hiding this comment.
The main issue is that this PR introduces too many unrelated changes, making it difficult to review the correctness and completeness of the types and tests. I strongly recommend splitting it into multiple atomic PRs. Thanks for your contribution!
| * @param {number | bigint} amount - The amount to burn in token's base units (must be ≤ 2^64-1). | ||
| * @returns {Promise<TransactionMessage>} The constructed transaction message. | ||
| */ | ||
| protected _buildSPLBurnTransactionMessage(token: string, amount: number | bigint): Promise<TransactionMessage>; |
Contributor
There was a problem hiding this comment.
We don't intent to support burn natively. Instead, the consumer will call sendTransaction on whatever they want.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR upgrades the
@tetherto/wdk-wallet-solanaSDK to support modern Solana capabilities, including Token-2022 (Token Extensions), token burn operations, and versioned transaction upgrades (Memo and Priority Fees).Specifically, it includes:
_getTokenProgram(mint)to support both the standard SPL Token program and the new Token-2022 program.npm run build:types.Motivation and Context
The Solana ecosystem is migrating heavily towards Token-2022 extensions, making it crucial for the SDK to interact seamlessly with these tokens.
Related Issue
PR fixes the following issue: N/A
Type of change