feat: add configurable text_shadow option#94
Open
DennisGaida wants to merge 3 commits into
Open
Conversation
Adds a text_shadow config option (0-3, default 1) that scales the directional drop shadow applied to all text and SVG icons across the card. Uses CSS custom properties (--card-text-shadow, --card-icon-filter) set on the weather-card root so they cascade automatically into all sub-component shadow roots (weather-clock, weather-details, hourly-forecast, daily-forecast) without any JS manipulation. Config: text_shadow: 1 # 0 = none, 1 = default, higher = stronger
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
For readability reasons, I sometimes would want more of a shadow behind the text and also behind the SVG icons. If for example a white cloud floats by sometimes the white text really is not very readable.
This adds a
text_shadowconfig option (0-3, default 1) that scales the directional drop shadow applied to all text and SVG icons across the card. Uses CSS custom properties (--card-text-shadow, --card-icon-filter) set on the weather-card root so they cascade automatically into all sub-component shadow roots (weather-clock, weather-details, hourly-forecast, daily-forecast) without any JS manipulation.Config:
text_shadow: 1 # 0 = none, 1 = default, higher = strongerType of Change
Related Issues
Fixes #
Checklist
bun run lintpassedbun run typecheckpassedbun run buildsuccessful