feat(config): add show_animations option to disable canvas animations#95
Open
r35krag0th wants to merge 1 commit into
Open
feat(config): add show_animations option to disable canvas animations#95r35krag0th wants to merge 1 commit into
r35krag0th wants to merge 1 commit into
Conversation
Author
|
-.- rebasing to |
Canvas weather animations can render light-colored elements (white clouds, sun rays) over white card text, making it unreadable. Add a show_animations config flag (default: true) that completely disables the canvas when set to false — no DOM node is created, the RAF loop never starts, and the animation manager is destroyed on live config change. Also surfaces the toggle in the visual card editor and adds translations for all 9 supported locales.
0fe4bfb to
00f41ab
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
show_animations: falseconfig flag to completely disable the canvas animation layer.canvas-containerDOM node is created, therequestAnimationFrameloop never starts, and callingdestroy()is triggered on live config change back tofalseshow_animationstranslation key to all 9 supported locales (en, de, fr, es, it, nl, ru, sk, hu)Motivation: Canvas weather animations (clouds, sun rays) render light-colored elements over white card text, making it unreadable in certain conditions. Users can now set
show_animations: falseto get a clean gradient background with no canvas overlay.card_mod users can also hide animations without this flag:
Test plan
show_animations: falsehides the canvas and gradient background renders cleanlyshow_animations: true(default/omitted) still shows animations as before