code optimization to prevent possible race condition issues#190
Open
sl-mikaelodokine wants to merge 3 commits intotexei:masterfrom
Open
code optimization to prevent possible race condition issues#190sl-mikaelodokine wants to merge 3 commits intotexei:masterfrom
sl-mikaelodokine wants to merge 3 commits intotexei:masterfrom
Conversation
Member
|
Sorry I missed that one, will have a look ! |
sl-mikaelodokine
force-pushed
the
master
branch
2 times, most recently
from
5f9cfc1 to
52270e7
Compare
…ingcalc commands - Increase default selector timeout from 5s to 30s for all sharingcalc commands (suspend, resume, recalculate) - Add --navigation-timeout flag to customize navigation timeout (default: 60s) - Add --selector-timeout flag to customize selector timeout (default: 30s) - Flag values are in seconds and converted to milliseconds internally - If flags are not provided, default values are used - Helps handle slow orgs or selectors that take time to appear
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello,
While trying to implement the sharingcalc commands, I noticed an instability in the expected result (without the plugin throwing an error).
Indeed, quite regularly (even often), clicking on the buttons does nothing in the target org.
After some testing, it turns out that this is due to a race condition issue. This PR aims to optimize the code to make it more robust and to prevent this problem from occurring again.