Draft
Harden reload-time label/ref recheck against stale document pointers#4564
Conversation
Copilot
AI
changed the title
[WIP] Fix crash when reloading files after change by another program
Harden reload-time label/ref recheck against stale document pointers
Jul 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reloads after external file changes could traverse document lists containing stale/invalid
LatexDocument*, leading to crashes while callinglabelItems()during structure/reference refresh. This change adds pointer-validity gating in the reload/recheck paths.Root cause containment: stale pointer filtering
LatexDocuments.labelItems()/recheckRefsLabels(), skip null pointers and pointers not present in the active set.Applied in all relevant traversal paths
LatexDocument::setMasterDocument(..., recheck=true)LatexDocument::recheckRefsLabels(...)(auto list/item aggregation branch)LatexDocuments::addDocsToLoad(...)(post-load syntax/ref refresh)Implementation notes
availableDocumentSet(...).